77004[BUGFIX] Process too many records on DataMap
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 1
Review log 67
-
Guillaume Germain uploaded patch set 1 12/09/22, 11:42
-
core-ci voted on patch set 1 V +1 12/09/22, 11:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34832
-
Guillaume Germain wrote 12/09/22, 12:32
Change destination moved from main to 10.4 -
Stefan Bürk commented on patch set 1 CR -1 12/09/22, 13:47
This should go to main + 11.5. And due our normal workflow from up to down, this needs an up-port first. Will take care of it on the weekend. First look looks like a legit approach, will have a deeper look on the upport then. -
Guillaume Germain commented on patch set 1 12/09/22, 14:30
Reply
Yes it's my fault, not used to contributing enough. You can find the review for the main branch: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77005 -
Stefan Bürk commented on patch set 1 12/09/22, 15:15
Reply
mhh they are now not connected due not reusing the change id. That was the reason why I suggested to do the up-port. I will abandon this 10.4 patch now. If main patch is reviewed and finished, a core merge will take care of the proper backport chain. That way the chain is documented later properly. So don't get the abandon wrong. It's just for handling cases and having later the same change id. You may want to read the TYPO3 Contribution Guide. Let me just point out some points (not complete) for eventually future contributin: * patches are done on the most upper branch, provide only the most upper patch. Normally this is the main branch. (If a bugfix is really only needed in a specific version, because new branches does not have that code anymore that is a other story). * backport's should be properly cherry-picked leaving the change id intact. You should normally not be in the need to do that, as this is the job of the core merger. * Releases: should state all branches which the patch needs to be "backported". Will do that on the new patch. -
Stefan Bürk abandoned the change 12/09/22, 15:15
Abandon because of https://review.typo3.org/c/Packages/TYPO3.CMS/+/77005 with anouther change id. To keep backport chain intact later, normal backpors should be done.