77005[BUGFIX] Avoid reaching placeholder limit in DataMapProcessor
Commit message
Review
-
Code review CR +2 Done
- Stefan Bürk +2
- Benni Mack +1
-
Verified V +2 Done
- Stefan Bürk +2
- Benni Mack +1
- core-ci +1 CI
Issues 1
Files 1
Review log 1827
Show 12 earlier messages
-
Guillaume Germain uploaded patch set 1 12/09/22, 14:27
-
core-ci voted on patch set 1 V -1 12/09/22, 14:38 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34836
-
Guillaume Germain uploaded patch set 2
V -112/09/22, 14:44 -
core-ci voted on patch set 2 V +1 12/09/22, 14:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34837
-
Stefan Bürk updated the commit message in patch set 3
V +112/09/22, 15:16 -
core-ci voted on patch set 3 V +1 12/09/22, 15:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34838
-
Stefan Bürk uploaded patch set 4
V +112/10/22, 17:40 -
Stefan Bürk commented on patch set 4 V +1 CR +1 12/10/22, 17:44
Thanks for the patch. Adjusted it slightly. *Backport Notes* 11.5 can be done the same way, Backport 10.4 must use patchset 1 solution, also the substraction from the placeholder limit should be increased than ( -100 instead of 10). Used methods from QueryBuilder are not existing in 10.4. -
core-ci voted on patch set 4 V +1 12/10/22, 17:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34857
-
Stefan Bürk uploaded patch set 5
CR +1V +112/10/22, 17:49 -
Stefan Bürk voted on patch set 5 V +1 CR +1 12/10/22, 17:49
-
Stefan Bürk voted on patch set 5 V 0 CR 0 12/10/22, 17:50
-
Stefan Bürk uploaded patch set 6 12/10/22, 17:55
-
Stefan Bürk commented on patch set 6 CR -1 12/10/22, 17:56
Not sure about the `fetchDependentElements` method ... if it does not eventually return duplicated result rows eventually. Needs to be checked. -
core-ci voted on patch set 5 V +1 12/10/22, 17:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34858
-
core-ci voted on patch set 6 V +1 12/10/22, 18:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34859
-
Benni Mack updated the commit message in patch set 7
CR -1V +105/03/23, 09:26 -
core-ci voted on patch set 7 V -1 05/03/23, 11:10 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41413
-
Oliver Hader rebased onto patch set 8
V -105/03/23, 12:39 -
core-ci voted on patch set 8 V +1 05/03/23, 13:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41530
-
Stefan Bürk commented on patch set 8 CR -1 07/03/23, 12:07
on it ...DataMapProcessor.php:1080I would say. it makes more sense to process the numeric filter across all ids before doing the chunking on the ids. -
Stefan Bürk uploaded patch set 9
CR -1V +107/03/23, 13:20 -
core-ci voted on patch set 9 V +1 07/03/23, 13:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43234
-
Stefan Bürk commented on patch set 9 V +1 CR +1 07/03/23, 13:32
DataMapProcessor.php:1080ReplyDone -
Benni Mack voted on patch set 9 V +1 CR +1 07/03/23, 17:51
-
Stefan Bürk voted on patch set 9 V +2 CR +2 07/04/23, 08:13
-
Stefan Bürk merged patch set 10 07/04/23, 08:13