Review main Merged

77005[BUGFIX] Avoid reaching placeholder limit in DataMapProcessor

Guillaume Germain CR +2 V +2 Normal +84 −73 updated 07/04/23, 08:13

Commit message

Use array chunked query combined with direct value list
to retrieve full data set in `DataMapProcessor` methods
`fetchTranslationValues` and `fetchDependentElements`.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Benni Mack +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1827

Show 12 earlier messages
  1. Guillaume Germain uploaded patch set 1 12/09/22, 14:27

  2. core-ci voted on patch set 1 V -1 12/09/22, 14:38 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34836

  1. Guillaume Germain uploaded patch set 2 V -1 12/09/22, 14:44

  2. core-ci voted on patch set 2 V +1 12/09/22, 14:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34837

  3. Stefan Bürk updated the commit message in patch set 3 V +1 12/09/22, 15:16

  4. core-ci voted on patch set 3 V +1 12/09/22, 15:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34838

  5. Stefan Bürk uploaded patch set 4 V +1 12/10/22, 17:40

  6. Stefan Bürk commented on patch set 4 V +1 CR +1 12/10/22, 17:44

    Thanks for the patch. Adjusted it slightly. *Backport Notes* 11.5 can be done the same way, Backport 10.4 must use patchset 1 solution, also the substraction from the placeholder limit should be increased than ( -100 instead of 10). Used methods from QueryBuilder are not existing in 10.4.
  7. core-ci voted on patch set 4 V +1 12/10/22, 17:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34857

  8. Stefan Bürk uploaded patch set 5 CR +1 V +1 12/10/22, 17:49

  9. Stefan Bürk voted on patch set 5 V +1 CR +1 12/10/22, 17:49

  10. Stefan Bürk voted on patch set 5 V 0 CR 0 12/10/22, 17:50

  11. Stefan Bürk uploaded patch set 6 12/10/22, 17:55

  12. Stefan Bürk commented on patch set 6 CR -1 12/10/22, 17:56

    Not sure about the `fetchDependentElements` method ... if it does not eventually return duplicated result rows eventually. Needs to be checked.
  13. core-ci voted on patch set 5 V +1 12/10/22, 17:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34858

  14. core-ci voted on patch set 6 V +1 12/10/22, 18:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34859

  15. Benni Mack updated the commit message in patch set 7 CR -1 V +1 05/03/23, 09:26

  16. core-ci voted on patch set 7 V -1 05/03/23, 11:10 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41413

  17. Oliver Hader rebased onto patch set 8 V -1 05/03/23, 12:39

  18. core-ci voted on patch set 8 V +1 05/03/23, 13:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41530

  19. Stefan Bürk commented on patch set 8 CR -1 07/03/23, 12:07

    on it ...

    DataMapProcessor.php:1080

    I would say. it makes more sense to process the numeric filter across all ids before doing the chunking on the ids.
  20. Stefan Bürk uploaded patch set 9 CR -1 V +1 07/03/23, 13:20

  21. core-ci voted on patch set 9 V +1 07/03/23, 13:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43234

  22. Stefan Bürk commented on patch set 9 V +1 CR +1 07/03/23, 13:32

    DataMapProcessor.php:1080 Reply

    Done
  23. Benni Mack voted on patch set 9 V +1 CR +1 07/03/23, 17:51

  24. Stefan Bürk voted on patch set 9 V +2 CR +2 07/04/23, 08:13

  25. Stefan Bürk merged patch set 10 07/04/23, 08:13