Review main Merged

77007[FEATURE] AdminPanel: Add SQL and memory metrics to toolbar

Christoph Lehmann CR +2 V +2 Normal +89 −12 updated 03/27/23, 15:56

Commit message

This extends the AdminPanel toolbar with more important metrics:

* Peak memory usage
* Amount of SQL queries
* Time spent doing SQL queries

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Andreas Kienast +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 1

Files 11

Review log 2941

Show 1216 earlier messages
  1. Christoph Lehmann uploaded patch set 1 12/09/22, 20:38

  2. core-ci voted on patch set 1 V -1 12/09/22, 20:45 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34840

  3. Oliver Klee commented on patch set 1 12/09/22, 21:45

    locallang_debug.xlf:11

    We should use numbers interpolations (otherwise it's not possible to reorder the interpolations when we change the wording or translater the text to a different language). <source>(%1$s Errors/Warnings, SQL: %2$sx / %3$s ms)</source> Also, for the values that are (positive) integers, we should use "u" instead of "s" (which is for strings). Reference for the format: https://www.php.net/manual/en/function.sprintf.php
  4. Oliver Klee commented on patch set 1 12/09/22, 21:46

    locallang_info.xlf:10

    Ditto about numbered interpolations and formats.
  5. Christoph Lehmann uploaded patch set 2 V -1 03/14/23, 20:13

  6. Christoph Lehmann uploaded patch set 3 03/14/23, 20:29

  7. Christoph Lehmann commented on patch set 3 03/14/23, 20:30

    locallang_debug.xlf:11 Reply

    Done

    locallang_info.xlf:10 Reply

    Done
  8. core-ci voted on patch set 2 V -1 03/14/23, 20:36 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38944

  9. core-ci voted on patch set 3 V -1 03/14/23, 20:56 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38945

  10. Christoph Lehmann uploaded patch set 4 V -1 03/15/23, 19:57

  11. core-ci voted on patch set 4 V -1 03/15/23, 20:23 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39006

  12. Josef Glatz commented on patch set 4 CR -1 03/15/23, 20:23

    locallang_debug.xlf:11

    Please change also the id/resname since this changes the "content logic" heavily

    locallang_info.xlf:10

    Please change also the id and resname since you change the "logic of the content"
  13. Christoph Lehmann uploaded patch set 5 CR -1 V -1 03/15/23, 20:52

  14. Christoph Lehmann commented on patch set 5 03/15/23, 20:52

    locallang_debug.xlf:11 Reply

    Done

    locallang_info.xlf:10 Reply

    Done
  15. Christoph Lehmann updated the commit message in patch set 6 03/15/23, 21:02

  16. Christoph Lehmann updated the commit message in patch set 7 03/15/23, 21:03

  1. core-ci voted on patch set 5 V -1 03/15/23, 21:09 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39010

  2. core-ci voted on patch set 6 V -1 03/15/23, 21:11 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39012

  3. core-ci voted on patch set 7 V -1 03/15/23, 21:12 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39013

  4. Christoph Lehmann uploaded patch set 8 V -1 03/15/23, 21:28

  5. core-ci voted on patch set 8 V +1 03/15/23, 21:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39020

  6. Georg Ringer commented on patch set 8 03/16/23, 03:27

    Should we transform it to a feature?
  7. Christoph Lehmann uploaded patch set 9 V +1 03/16/23, 22:30

  8. Christoph Lehmann commented on patch set 9 03/16/23, 22:30

    Reply

    Done
  9. core-ci voted on patch set 9 V +1 03/16/23, 22:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39083

  10. Georg Ringer voted on patch set 9 CR +2 03/17/23, 07:20

  11. Georg Ringer voted on patch set 9 V +1 CR +1 03/17/23, 07:20

  12. Stefan Bürk commented on patch set 9 CR -1 03/18/23, 10:03

    Thanks for your work on this. However, there is a hidden trap making this "breaking". See my comments, I think I have outlined how this can be changed to a non-breaking approach. Meaning, getting this features now but having a safety-net and doing the breaking things when we are allowed to do breaking things.

    MainController.php:112

    As commented for the `ShortInfoProviderInterface` hard enforcing the `setData()` method is **breaking**. Therefore, we should do this conditional based here: * 1. check for the interface * 2. check if method exists, if use it otherwise trigger a deprecation notice The depcrecation method should state, that a module implements the `ShortInfoProviderInterface` it **must** implement the setData() method at least with TYPO3 v13. Sadly, this is technically not a "deprecation" in the sense of "this gets removed" - but we could consider it as deprecated that the interface needs that method. Not sure, how this have been done in the past.

    AbstractModule.php:35

    Generic data feels kind of not right. Can we renamte it at least to `$moduleData` or similar ?

    ShortInfoProviderInterface.php:44

    This interface is `PublicAPI`. Enforcing now a new method to be implemented is a breaking change, shortly before freeze phase. We should have the method commented out here, and guard code using it to check if method exists or something like that to avoid "breakage". See `MainController`comments on that. A corresponding @todo should be added here to activate the method for 13.0 (breaking phase). Along with a deprecation notice in `MainController` this seems to be the proper way to handle this for me and get this feature basically in now.
  13. Christoph Lehmann uploaded patch set 10 CR +1 V +1 03/25/23, 21:14

  14. core-ci voted on patch set 10 V +1 03/25/23, 21:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39630

  15. Christoph Lehmann commented on patch set 10 03/25/23, 21:23

    MainController.php:112 Reply

    Done

    AbstractModule.php:35 Reply

    Done

    ShortInfoProviderInterface.php:44 Reply

    Done
  16. Stefan Bürk commented on patch set 10 03/26/23, 20:33

    MainController.php:117

    The deprecation message should only be triggered, if * module implementes ShortInfoProviderInterface * **and** do not implement method `setModuleData()` yet Currently, it is triggered for modules regardeless if they implement the interface or not. Additionally, I would suggest to wrapp the message to be kind in a lower line length ... albit this is more a nitpick. But as you have to rework here ;)
  17. Christoph Lehmann uploaded patch set 11 V +1 03/27/23, 07:06

  18. Christoph Lehmann commented on patch set 10 03/27/23, 07:08

    MainController.php:117 Reply

    Seems it was too late ;-)
  19. core-ci voted on patch set 11 V +1 03/27/23, 07:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39663

  20. Stefan Bürk commented on patch set 11 V +1 CR +1 03/27/23, 15:05

    Thanks for taking care of my comments. Looks fine now.
  21. Andreas Kienast uploaded patch set 12 CR +1 V +1 03/27/23, 15:29

  22. Andreas Kienast voted on patch set 12 V +1 CR +1 03/27/23, 15:30

  23. core-ci voted on patch set 12 V +1 03/27/23, 15:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39706

  24. Stefan Bürk voted on patch set 12 V +2 CR +2 03/27/23, 15:56

  25. Stefan Bürk merged patch set 13 03/27/23, 15:56