Review main Merged

77012[BUGFIX] Honor shift-reload in FE TypoScript

Christian Kuhn CR +2 V +2 Easy +40 −9 updated 02/07/23, 07:47

Commit message

The patch fixes that pressing "shift-reload" in a
Frontend request with a logged in Backend user no
longer honored changed TypoScript from included
TypoScript files.

The cache layer for included TypoScript files is
more agressive in v12 and TypoScript in general
is calculated less often. Together with the
removal of "pagesection" cache and the simplified
locking behavior, the current detection of
"shift-reload" kicked in only at a later point
when TypoScript had been determined already.

The patch moves the "shift-reload" detection to
an earlier point: To the BackendUserAuthentication
Frontend Middleware. This is a better place to
put such code anyway.

Additionally, the Changelog is improved to
outline more details on changed TypoScript
cache behavior.

In general, the Frontend "no_cache" related code
is still spread out at various places and is
pretty messy. It is planned to streamline this
with further patches.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Anja Leichsenring +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Anja Leichsenring +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 2

Files 3

Review log 911

  1. Christian Kuhn uploaded patch set 1 12/10/22, 13:30

  2. Christian Kuhn updated the commit message in patch set 2 12/10/22, 13:38

  3. core-ci voted on patch set 1 V +1 12/10/22, 13:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34853

  4. core-ci voted on patch set 2 V +1 12/10/22, 13:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34854

  5. Stefan Bürk voted on patch set 2 V +1 CR +1 12/10/22, 14:15

  6. Anja Leichsenring voted on patch set 2 V +1 CR +1 12/10/22, 14:35

  7. Christian Kuhn voted on patch set 2 V +2 CR +2 12/10/22, 14:41

  8. Christian Kuhn merged patch set 3 12/10/22, 14:41

  9. Oliver Hader commented on patch set 3 02/06/23, 19:51

    Currently caches are only used, when `no_cache` is set, but never under regular conditions...

    TypoScriptFrontendController.php:1567

    `$this->no_cache` vs `$event->shouldUseCachedPageData()`
  10. Christian Kuhn commented on patch set 3 02/06/23, 20:22

    TypoScriptFrontendController.php:1567 Reply

  11. Oliver Hader commented on patch set 3 02/07/23, 07:47

    TypoScriptFrontendController.php:1567 Reply

    Fixed. Thx!