Review main Merged

77013[BUGFIX] Allow relative @import wildcard includes

Christian Kuhn CR +2 V +2 Easy +38 −1 updated 12/10/22, 21:10

Commit message

Scenario:
sys_template record
@import 'EXT:core/Configuration/TypoScript/foo.typoscript'

File EXT:core/Configuration/TypoScript/foo.typoscript:
@import './Setup/*.typoscript'

File EXT:core/Configuration/TypoScript/Setup/bar.typoscript:
page.20 = TEXT
page.20.value = bar.typoscript

Expected output:
"bar.typoscript"

Loading a relative sub-directory include with a wildcard
for files worked in TYPO3 v11 and broke with v12. The patch
adds this again and adds coverage for this rather nasty
scenario.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 2

Files 4

Review log 67

  1. Christian Kuhn uploaded patch set 1 12/10/22, 18:13

  2. core-ci voted on patch set 1 V +1 12/10/22, 18:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34860

  3. Stefan Bürk voted on patch set 1 CR +1 12/10/22, 19:28

  4. Benni Mack voted on patch set 1 V +1 CR +1 12/10/22, 19:31

  5. Stefan Bürk voted on patch set 1 V +1 12/10/22, 19:31

  6. Christian Kuhn voted on patch set 1 V +2 CR +2 12/10/22, 21:09

  7. Christian Kuhn merged patch set 2 12/10/22, 21:10