Review main Merged

77015[DOCS] Update TypoScript info on file includes within curly braces

Christian Kuhn CR +2 V +2 Normal +50 −2 updated 12/12/22, 08:58

Commit message

Clearly state

foo {
  @import '...'
}

is not relative to 'foo' anymore and a construct
like this must be avoided or breaks when upgrading
to TYPO3 v12.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Chris Müller +1
    • Lina Wolf +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Chris Müller +1
    • Lina Wolf +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 912

  1. Christian Kuhn uploaded patch set 1 12/10/22, 21:54

  2. Christian Kuhn updated the commit message in patch set 2 12/10/22, 21:58

  3. core-ci voted on patch set 1 V +1 12/10/22, 22:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34863

  4. Stefan Bürk commented on patch set 2 V +1 CR +1 12/10/22, 22:05

    ack.
  5. core-ci voted on patch set 2 V +1 12/10/22, 22:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34864

  6. Chris Müller uploaded patch set 3 CR +1 V +1 12/11/22, 06:32

  7. Chris Müller voted on patch set 3 V +1 CR +1 12/11/22, 06:33

  8. core-ci voted on patch set 3 V +1 12/11/22, 06:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34872

  9. Lina Wolf voted on patch set 3 V +1 CR +1 12/11/22, 11:31

  10. Oli Bartsch voted on patch set 3 CR +2 12/12/22, 08:58

  11. Oli Bartsch voted on patch set 3 V +2 12/12/22, 08:58

  12. Oli Bartsch merged patch set 4 12/12/22, 08:58