Review main Merged

77017[TASK] Improve TypoScript submodule naming

Jasmina Ließmann CR +2 V +2 Normal +124 −89 updated 01/06/23, 15:39

Commit message

By renaming the submodules of the ext:tstemplate "TypoScript" backend
module and adding descriptive texts, it makes it clearer and more
beginner-friendly for what each submodule is used for.

The headings of the submodules now also correspond to the names of
corresponding option in the submodule selector.

By renaming words like "template" to "TypoScript template" a
unified wording will be used.

Furthermore, the submodule "TypoScript Records" is now set as default.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 14

Review log 1219

  1. Jasmina Ließmann uploaded patch set 1 12/11/22, 13:43

  2. core-ci voted on patch set 1 V -1 12/11/22, 13:51 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34878

  3. Jasmina Ließmann uploaded patch set 2 V -1 12/11/22, 14:31

  4. core-ci voted on patch set 2 V -1 12/11/22, 14:40 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34879

  5. Jasmina Ließmann uploaded patch set 3 V -1 12/11/22, 14:54

  6. core-ci voted on patch set 3 V -1 12/11/22, 15:03 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34880

  7. Jasmina Ließmann uploaded patch set 4 V -1 12/11/22, 15:44

  8. core-ci voted on patch set 4 V -1 12/11/22, 15:53 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34881

  9. Jasmina Ließmann uploaded patch set 5 V -1 12/11/22, 18:32

  10. core-ci voted on patch set 5 V -1 12/11/22, 18:41 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34883

  11. Jasmina Ließmann uploaded patch set 6 V -1 12/11/22, 19:10

  12. core-ci voted on patch set 6 V +1 12/11/22, 19:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34884

  13. Oli Bartsch updated the commit message in patch set 7 V +1 12/16/22, 10:56

  14. Oli Bartsch commented on patch set 7 12/16/22, 11:03

    Modules.php:27

    This change looks unrelated one the one hand and on the other hand is the intention not really clear to me. Would you mind to revert this change?

    locallang.xlf:9

    Not quite sure if it would be better to directly introduce new keys for the new names. I otherwise fear this might lead to confusion in the long run.
  15. core-ci voted on patch set 7 V +1 12/16/22, 11:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35194

  16. Jasmina Ließmann commented on patch set 7 01/04/23, 21:03

    Modules.php:27 Reply

    The change is intended to first get an overview of the available TypoScript files.

    locallang.xlf:9 Reply

    I would love to completely merge the language files and give several keys new names! After a consultation with Lolli, the existing locallang files and keys should be left as they are, otherwise the translators would have to do too much work. With the new keys I tried to stick to the previous naming to keep it somehow consistent.
  17. Christian Kuhn commented on patch set 7 V +1 CR +1 01/05/23, 13:26

    Modules.php:27 Reply

    Ack

    locallang.xlf:9 Reply

    Ack
  18. Stefan Bürk commented on patch set 7 V +2 CR +2 01/06/23, 15:38

    Finally ... this should help to avoid confusings for new peoples. Thanks for this @Jasmina.
  19. Stefan Bürk merged patch set 8 01/06/23, 15:39