Review main Merged

77019[FEATURE] Add stdWrap to config.additionalHeaders

Christoph Lehmann CR +2 V +2 Easy +40 −1 updated 02/06/23, 20:55

Commit message

StdWrap properties have been added to the `header` directive in `config.additionalHeaders`.

It is now possible to sent dynamic HTTP headers with TypoScript, especially headers that contain paths to extension files.

Example:

config.additionalHeaders {
   10 {
       header = link: <{path : EXT:site/Resources/Public/Fonts/icon.woff2}>; rel=preload; as=font; crossorigin
       header.insertData = 1
   }
}

Review

  • Code review CR +2 Done
    • Anja Leichsenring +2
    • Benni Mack +1
  • Verified V +2 Done
    • Anja Leichsenring +2
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 79

  1. Christoph Lehmann uploaded patch set 1 12/11/22, 23:00

  2. core-ci voted on patch set 1 V +1 12/11/22, 23:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34889

  3. Christoph Lehmann uploaded patch set 2 V +1 12/27/22, 10:16

  4. core-ci voted on patch set 2 V +1 12/27/22, 10:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35363

  5. Benni Mack voted on patch set 2 CR +1 01/07/23, 19:20

  6. Benni Mack voted on patch set 2 V +1 01/09/23, 13:44

  7. Anja Leichsenring voted on patch set 2 V +2 CR +2 01/10/23, 10:40

  8. Anja Leichsenring merged patch set 3 01/10/23, 10:40

  9. Christian Kuhn wrote 02/06/23, 20:55

    Created a revert of this change as I895ea267da31845660dd07b6f8cfe50d0c5cef69