Review main Merged

77021[BUGFIX] Properly detect multiline TypoScript comments

Christian Kuhn CR +2 V +2 Hard +885 −80 updated 01/04/23, 17:14

Commit message

The TypoScript (production) LossyTokenizer fails to
detect multiline comments properly. The patch
refactors the class accordingly and increases
test coverage regarding "/* ... */" comments.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oli Bartsch +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Oli Bartsch +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 2

Files 2

Review log 1419

  1. Christian Kuhn uploaded patch set 1 12/12/22, 09:13

  2. Christian Kuhn voted on patch set 1 CR -1 12/12/22, 09:14

  3. core-ci voted on patch set 1 V -1 12/12/22, 09:21 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34903

  4. Christian Kuhn uploaded patch set 2 CR -1 V -1 12/16/22, 12:27

  5. core-ci voted on patch set 2 V +1 12/16/22, 12:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35195

  6. Christian Kuhn uploaded patch set 3 V +1 01/04/23, 14:44

  7. core-ci voted on patch set 3 V +1 01/04/23, 14:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35461

  8. Christian Kuhn uploaded patch set 4 V +1 01/04/23, 15:01

  9. core-ci voted on patch set 4 V +1 01/04/23, 15:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35463

  10. Christian Kuhn uploaded patch set 5 V +1 01/04/23, 15:13

  11. Christian Kuhn uploaded patch set 6 01/04/23, 15:16

  12. Christian Kuhn uploaded patch set 7 01/04/23, 15:23

  13. Christian Kuhn uploaded patch set 8 01/04/23, 15:24

  14. core-ci voted on patch set 8 V +1 01/04/23, 15:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35468

  15. Stefan Bürk voted on patch set 8 CR +1 01/04/23, 16:08

  16. Stefan Bürk voted on patch set 8 V +1 01/04/23, 16:14

  17. Oli Bartsch voted on patch set 8 V +1 CR +1 01/04/23, 17:13

  18. Christian Kuhn voted on patch set 8 V +2 CR +2 01/04/23, 17:14

  19. Christian Kuhn merged patch set 9 01/04/23, 17:14