77023[BUGFIX] Properly respect allowEdit setting in PasswordGenerator
Commit message
Review
-
Code review CR +2 Done
- Oli Bartsch +2
- Frank Nägler +1
- Benni Mack +1
-
Verified V +2 Done
- Oli Bartsch +2
- Frank Nägler +1
- Benni Mack +1
- core-ci +1 CI
Issues 2
Files 2
Review log 1013
-
Oli Bartsch uploaded patch set 1 12/12/22, 10:37
-
core-ci voted on patch set 1 V +1 12/12/22, 10:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34907
-
Andreas Kienast voted on patch set 1 V +1 CR +1 12/12/22, 10:57
-
Frank Nägler commented on patch set 1 12/12/22, 14:10
From my point of view, allowEdit should also disable the clear icon in the field. allowEdit = false means also do not delete existing values. Opinions? -
Oli Bartsch uploaded patch set 2
CR +1V +112/12/22, 16:00 -
Oli Bartsch commented on patch set 2 12/12/22, 16:00
Reply
Good catch. Thanks! -
Oli Bartsch uploaded patch set 3 12/12/22, 16:04
-
core-ci voted on patch set 2 V +1 12/12/22, 16:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34923
-
Frank Nägler voted on patch set 3 V +1 CR +1 12/12/22, 16:11
-
core-ci voted on patch set 3 V +1 12/12/22, 16:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34924
-
Benni Mack voted on patch set 3 V +1 CR +1 12/12/22, 16:21
-
Oli Bartsch voted on patch set 3 V +2 CR +2 12/12/22, 16:23
-
Oli Bartsch merged patch set 4 12/12/22, 16:23