77031[BUGFIX] Avoid notices while retrieving the cookie domain
Commit message
Review
-
Code review CR +2 Done
- Stefan Bürk +2
- Oliver Klee +1
- Benni Mack +1
-
Verified V +2 Done
- Stefan Bürk +2
- Benni Mack +1
- core-ci +1 CI
Issues 1
Files 1
Review log 1012
-
Georg Ringer uploaded patch set 1 12/12/22, 14:50
-
Georg Ringer commented on patch set 1 12/12/22, 14:50
This change is ready for review. -
Stefan Bürk commented on patch set 1 12/12/22, 14:52
AbstractUserAuthentication.php:352This one is superflous, as guarded/covered by `empty()` -
Stefan Bürk commented on patch set 1 12/12/22, 14:55
AbstractUserAuthentication.php:350Wonder why this is "not set" or "null" ... this is defined in default configuration as string, so some extension must remove or override it. *typo3/sysext/core/Configuration/DefaultConfiguration.php* ``` 'cookieDomain' => '', ``` The guard is okay, but in the end not the "source" of the issue I would say. -
core-ci voted on patch set 1 V +1 12/12/22, 14:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34920
-
Thomas Hohn uploaded patch set 2
V +103/16/23, 16:40 -
Thomas Hohn commented on patch set 2 03/16/23, 16:41
AbstractUserAuthentication.php:350ReplyAckAbstractUserAuthentication.php:352ReplyDone -
core-ci voted on patch set 2 V +1 03/16/23, 16:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39063
-
Oliver Klee voted on patch set 2 CR +1 03/16/23, 16:56
-
Benni Mack voted on patch set 2 V +1 CR +1 03/16/23, 21:56
-
Stefan Bürk voted on patch set 2 V +2 CR +2 03/17/23, 05:26
-
Stefan Bürk merged patch set 3 03/17/23, 05:26