77032[TASK] Relax strict usage of approved translations
Commit message
Review
-
Code review CR +2 Done
- Anja Leichsenring +2
- Guido Schmechel +1
- Stefan Bürk +1
- Christian Kuhn +1
- Jörg Bösche +1
-
Verified V +2 Done
- Anja Leichsenring +2
- Stefan Bürk +1
- core-ci +1 CI
Issues 2
Files 3
Review log 1620
-
Georg Ringer uploaded patch set 1 12/12/22, 15:01
-
Georg Ringer commented on patch set 1 12/12/22, 15:01
This change is ready for review. -
core-ci voted on patch set 1 V +1 12/12/22, 15:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34921
-
Benni Mack uploaded patch set 2
V +112/12/22, 16:15 -
core-ci voted on patch set 2 V +1 12/12/22, 16:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34928
-
Guido Schmechel voted on patch set 2 CR +1 12/15/22, 23:28
-
Frank Nägler voted on patch set 2 CR +1 12/16/22, 13:01
-
Benni Mack updated the commit message in patch set 3
CR +1V +112/20/22, 17:19 -
Benni Mack voted on patch set 3 V +1 CR +1 12/20/22, 17:19
-
core-ci voted on patch set 3 V +1 12/20/22, 17:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35246
-
Georg Ringer rebased onto patch set 4
CR +1V +112/29/22, 08:40 -
core-ci voted on patch set 4 V +1 12/29/22, 08:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35389
-
Guido Schmechel voted on patch set 4 CR +1 12/29/22, 09:20
-
Christian Kuhn commented on patch set 4 01/05/23, 15:30
I don't get it: What is the practical use case of the 'approved' feature, when the default falls back 'yes'? Could you elaborate on the feature a bit? -
Georg Ringer commented on patch set 4 01/12/23, 11:02
Reply
use case is having the feature flag enabled, so only approved translations and now there is an e.g. manually created xlf file or just one from an upgrade with translations but because there is *NO* approved flag at all, those translations are not taken into account. -
Christian Kuhn commented on patch set 4 CR +1 01/12/23, 11:38
Reply
Aha. Ok. will give +1 reading. -
Stefan Bürk voted on patch set 4 V +1 CR +1 01/13/23, 08:36
-
Jörg Bösche voted on patch set 4 CR +1 01/13/23, 09:07
-
Anja Leichsenring voted on patch set 4 V +2 CR +2 01/17/23, 09:26
-
Anja Leichsenring merged patch set 5 01/17/23, 09:26