77033[TASK] Provide more information to itemsProcFunc calls
Commit message
Review
-
Code review CR +2 Done
- Oli Bartsch +2
- Garvin Hicking +1
-
Verified V +2 Done
- Oli Bartsch +2
- Garvin Hicking +1
- core-ci +1 CI
Issues 1
Files 7
- typo3/sysext/backend/Classes/Form/FormDataProvider/AbstractItemProvider.php3+2 −1
- typo3/sysext/backend/Tests/Functional/Form/FormDataProvider/TcaSelectItemsTest.php+9 −0
- typo3/sysext/backend/Tests/Unit/Form/FormDataProvider/TcaCheckboxItemsTest.php+7 −0
- typo3/sysext/backend/Tests/Unit/Form/FormDataProvider/TcaRadioItemsTest.php+7 −0
- typo3/sysext/backend/Tests/Unit/Utility/BackendUtilityTest.php+8 −0
- typo3/sysext/core/Classes/DataHandling/ItemProcessingService.php+19 −0
- typo3/sysext/core/Configuration/Services.yaml+3 −0
Review log 2943
Show 1118 earlier messages
-
Georg Ringer uploaded patch set 1 12/12/22, 15:26
-
Georg Ringer commented on patch set 1 12/12/22, 15:27
This change is ready for review. -
core-ci voted on patch set 1 V -1 12/12/22, 15:34 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34922
-
Georg Ringer uploaded patch set 2
V -112/13/22, 05:11 -
core-ci voted on patch set 2 V +1 12/13/22, 05:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34972
-
Stefan Froemken voted on patch set 2 V +1 CR +1 12/13/22, 06:42
-
Oli Bartsch commented on patch set 2 V -1 12/13/22, 07:20
AbstractItemProvider.php:97itemsProcFunc is also called in the DataHandler. The new options are not yet added there. This will therefore lead to inconsistency, since the available hook options would depend on the context they are called in. -
Georg Ringer rebased onto patch set 3
CR +1V +112/14/22, 08:56 -
core-ci voted on patch set 3 V +1 12/14/22, 09:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35082
-
Oli Bartsch commented on patch set 3 V -1 12/14/22, 09:39
AbstractItemProvider.php:97Replystill applies -
Georg Ringer uploaded patch set 4
V +112/14/22, 09:59 -
core-ci voted on patch set 4 V -1 12/14/22, 10:11 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35088
-
Georg Ringer uploaded patch set 5
V -112/14/22, 10:40 -
core-ci voted on patch set 5 V -1 12/14/22, 10:51 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35091
-
Stefan Froemken uploaded patch set 6
V -112/20/22, 08:22 -
core-ci voted on patch set 6 V -1 12/20/22, 08:34 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35240
-
Stefan Froemken uploaded patch set 7
V -112/20/22, 09:45 -
core-ci voted on patch set 7 V -1 12/20/22, 09:57 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35241
-
Stefan Froemken uploaded patch set 8
V -112/20/22, 10:00 -
core-ci voted on patch set 8 V +1 12/20/22, 10:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35242
-
Benni Mack updated the commit message in patch set 9
V +105/03/23, 09:26 -
Oli Bartsch uploaded patch set 10 07/06/23, 20:52
-
Oli Bartsch uploaded patch set 11 07/06/23, 20:54
-
Oli Bartsch commented on patch set 11 V +1 CR +1 07/06/23, 21:02
AbstractItemProvider.php:97ReplyDone -
core-ci voted on patch set 10 V -1 07/06/23, 21:05 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43834
-
core-ci voted on patch set 11 V -1 07/06/23, 21:05 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43835
-
Benjamin Franzke rebased onto patch set 12
CR +1V +107/06/23, 22:19Rebase after revert -
core-ci voted on patch set 12 V +1 07/06/23, 22:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43843
-
Stefan Froemken voted on patch set 12 V +1 CR +1 07/07/23, 07:30
-
Georg Ringer rebased onto patch set 13
CR +1V +110/09/23, 18:14 -
core-ci voted on patch set 13 V +1 10/09/23, 18:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47614
-
Garvin Hicking voted on patch set 13 CR +1 V +1 12/06/23, 12:09
-
Garvin Hicking commented on patch set 13 12/06/23, 12:11
(Merge conflict could be resolved, only a change in order of new elements in `typo3/sysext/core/Configuration/Services.yaml`) -
Jörg Bösche voted on patch set 13 CR +1 12/15/23, 10:23
-
Oli Bartsch uploaded patch set 14
CR +1V +112/19/23, 08:41 -
Oli Bartsch voted on patch set 14 CR +1 V +1 12/19/23, 08:43
-
core-ci voted on patch set 14 V -1 12/19/23, 08:52 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50793
-
Oli Bartsch uploaded patch set 15
CR +1V +112/19/23, 10:06 -
core-ci voted on patch set 15 V +1 12/19/23, 10:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50800
-
Oli Bartsch voted on patch set 15 CR +1 V +1 12/19/23, 10:49
-
Garvin Hicking voted on patch set 15 CR +1 V +1 12/20/23, 10:21
-
Oli Bartsch voted on patch set 15 CR +2 V +2 12/20/23, 10:23
-
Oli Bartsch merged patch set 16 12/20/23, 10:43