Review 10.4 Merged

77038[TASK] Add HTTP host header injection check to reports module

Oliver Hader CR +2 V +2 Normal +113 −1 updated 12/13/22, 09:12

Commit message

In case the web server scenario is not properly configured to deny
HTTP host header injection, and the trustedHostsPattern is not explicit
enough, a corresponding check in the reports module will issue
an error message like

* HTTP_HOST contained unexpected "a0a3aa2f59.random.example.org"
* SERVER_NAME contained unexpected "a0a3aa2f59.random.example.org"

Using the configuration directive `UseCanonicalName On` for Apache
web server environments mitigates the risk.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Benjamin Franzke +1
  • Verified V +2 Done
    • Benni Mack +2
    • Benjamin Franzke +1
    • core-ci +1 CI

Issues 1

Files 5

Review log 68

  1. Oliver Hader uploaded patch set 1 12/12/22, 18:05

  2. core-ci voted on patch set 1 V +1 12/12/22, 18:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34938

  3. Nikita Hovratov updated the commit message in patch set 2 V +1 12/12/22, 18:27

  4. core-ci voted on patch set 2 V +1 12/12/22, 18:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34941

  5. Benni Mack voted on patch set 2 V +1 CR +1 12/12/22, 20:26

  6. Benjamin Franzke voted on patch set 2 V +1 CR +1 12/13/22, 06:42

  7. Benni Mack voted on patch set 2 V +2 CR +2 12/13/22, 09:12

  8. Benni Mack merged patch set 3 12/13/22, 09:12