Review main Merged

7706[FEATURE] Enable TCA type field to depend on field of foreign table

Ingmar Schlecht CR +2 V +2 Normal +106 −21 updated 06/03/13, 20:49

Commit message

TCA type fields can now refer to a field on a foreign record with a colon-separated
syntax (e.g. uid_local:type).  This will be used by sys_file_references table, where
the type (showItems) depends on a value on the foreign record (sys_file)

Review

  • Code review CR +2
    • Oliver Hader +2
  • Verified V +2
    • Oliver Hader +2

Issues 1

Files 2

Review log 20

  1. Ingmar Schlecht commented on patch set 1 01/31/12, 13:52

    OK, the documentation is now at http://forge.typo3.org/issues/33065 As for the CGL stuff, I find the space rather ridiculous and the comment was there before. But if you mind, I don't mind if you fix it. ;-)
  2. Ingmar Schlecht commented on patch set 2 01/31/12, 13:52

    This patch is on hold for the moment. I just noticed there is another function to read out the type value of a record in t3lib_BEfunc (getTCAtypeValue) which needs to be adopted too.
  3. Ingmar Schlecht uploaded patch set 3 01/31/12, 13:52

  4. Ingmar Schlecht commented on patch set 3 01/31/12, 13:52

    Hi Tolleiv, thanks for reviewing. I added a test extension (very quick n dirty) and a test T3D with records to the forge issue: http://forge.typo3.org/issues/33045 cheers Ingmar
  5. Ingmar Schlecht uploaded patch set 4 01/31/12, 13:52

  6. Ingmar Schlecht uploaded patch set 5 01/31/12, 13:52

  7. Tolleiv Nietsch commented on patch set 3 01/31/12, 13:52

    Looks good to me, but someone else must approve Code look "good" but I wonder if there's an easy way to test it? E.g. within the irre_tutorial ?
  8. Tolleiv Nietsch commented on patch set 3 V 0 01/31/12, 13:52

    Cool stuff - works like a charm.
  9. Markus Klein uploaded patch set 2 01/31/12, 13:52

  10. Oliver Hader commented on patch set 4 01/31/12, 13:52

    Verified; Looks good to me, but someone else must approve Looks good in general, however, I've got some smaller remarks: * CGL issues (see comments) ** strstr could be strpos ** "if(" misses as whitespace * group/select fields could also contain more than one record, so this needs to be checked/documented (e.g. only take the first one)
  11. Georg Ringer commented on patch set 1 01/31/12, 13:52

    (2 inline comments) dont forget an issue for the doc

    class.t3lib_tceforms.php:3054

    missng space after "if"

    class.t3lib_tceforms.php:3082

    comment should be before the if
  12. Philipp Gampe commented on patch set 2 01/31/12, 13:52

    Looks good to me, but someone else must approve Unit tests would be cool too. If you have some spare time ...
  13. Mr. Jenkins commented on patch set 1 01/31/12, 13:52

  14. Mr. Jenkins commented on patch set 2 01/31/12, 13:52

  15. Mr. Jenkins commented on patch set 3 01/31/12, 13:52

  16. Mr. Jenkins commented on patch set 4 01/31/12, 13:52

  17. Mr. Jenkins commented on patch set 5 01/31/12, 13:52

  18. Wouter Wolters commented on patch set 3 01/31/12, 13:52

    Verified; Looks good to me, but someone else must approve
  19. Oliver Hader commented on patch set 5 V 0 01/31/12, 13:52

    by team member; Looks good to me, approved Thanks for doing the changes... with Tolleiv's review: +2
  20. Oliver Hader merged patch set 5 01/31/12, 13:52