7706[FEATURE] Enable TCA type field to depend on field of foreign table
Commit message
Review
-
Code review CR +2
- Oliver Hader +2
-
Verified V +2
- Oliver Hader +2
Issues 1
Files 2
Review log 20
-
Ingmar Schlecht commented on patch set 1 01/31/12, 13:52
OK, the documentation is now at http://forge.typo3.org/issues/33065 As for the CGL stuff, I find the space rather ridiculous and the comment was there before. But if you mind, I don't mind if you fix it. ;-) -
Ingmar Schlecht commented on patch set 2 01/31/12, 13:52
This patch is on hold for the moment. I just noticed there is another function to read out the type value of a record in t3lib_BEfunc (getTCAtypeValue) which needs to be adopted too. -
Ingmar Schlecht uploaded patch set 3 01/31/12, 13:52
-
Ingmar Schlecht commented on patch set 3 01/31/12, 13:52
Hi Tolleiv, thanks for reviewing. I added a test extension (very quick n dirty) and a test T3D with records to the forge issue: http://forge.typo3.org/issues/33045 cheers Ingmar -
Ingmar Schlecht uploaded patch set 4 01/31/12, 13:52
-
Ingmar Schlecht uploaded patch set 5 01/31/12, 13:52
-
Tolleiv Nietsch commented on patch set 3 01/31/12, 13:52
Looks good to me, but someone else must approve Code look "good" but I wonder if there's an easy way to test it? E.g. within the irre_tutorial ? -
Tolleiv Nietsch commented on patch set 3 V 0 01/31/12, 13:52
Cool stuff - works like a charm. -
Markus Klein uploaded patch set 2 01/31/12, 13:52
-
Oliver Hader commented on patch set 4 01/31/12, 13:52
Verified; Looks good to me, but someone else must approve Looks good in general, however, I've got some smaller remarks: * CGL issues (see comments) ** strstr could be strpos ** "if(" misses as whitespace * group/select fields could also contain more than one record, so this needs to be checked/documented (e.g. only take the first one) -
Georg Ringer commented on patch set 1 01/31/12, 13:52
(2 inline comments) dont forget an issue for the docclass.t3lib_tceforms.php:3054missng space after "if"class.t3lib_tceforms.php:3082comment should be before the if -
Philipp Gampe commented on patch set 2 01/31/12, 13:52
Looks good to me, but someone else must approve Unit tests would be cool too. If you have some spare time ... -
Mr. Jenkins commented on patch set 1 01/31/12, 13:52
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/2920/ : SUCCESS -
Mr. Jenkins commented on patch set 2 01/31/12, 13:52
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/2930/ : SUCCESS -
Mr. Jenkins commented on patch set 3 01/31/12, 13:52
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/3018/ : SUCCESS -
Mr. Jenkins commented on patch set 4 01/31/12, 13:52
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/3065/ : SUCCESS -
Mr. Jenkins commented on patch set 5 01/31/12, 13:52
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/3069/ : SUCCESS -
Wouter Wolters commented on patch set 3 01/31/12, 13:52
Verified; Looks good to me, but someone else must approve -
Oliver Hader commented on patch set 5 V 0 01/31/12, 13:52
by team member; Looks good to me, approved Thanks for doing the changes... with Tolleiv's review: +2 -
Oliver Hader merged patch set 5 01/31/12, 13:52