77072[FEATURE] Use password policies in installer and setup command
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Torben Hansen +1
-
Verified V +2 Done
- Benni Mack +2
- Torben Hansen +1
- core-ci +1 CI
Issues 1
Files 9
- Build/Sources/TypeScript/install/installer.ts+2 −1
- typo3/sysext/core/Documentation/Changelog/12.2/Feature-77072-UsePasswordPolicyForInstall.rstnew+26 −0
- typo3/sysext/core/Tests/Acceptance/Install/Mysql/BlankPageCest.php+2 −2
- typo3/sysext/core/Tests/Acceptance/Install/Postgresql/BlankPageCest.php+2 −2
- typo3/sysext/core/Tests/Acceptance/Install/Sqlite/BlankPageCest.php+2 −2
- typo3/sysext/install/Classes/Command/SetupCommand.php3+4 −2
- typo3/sysext/install/Classes/Controller/InstallerController.php3+13 −3
- typo3/sysext/install/Classes/Service/SetupDatabaseService.php2+16 −2
- typo3/sysext/install/Resources/Public/JavaScript/installer.js+1 −1
Review log 2738
Show 913 earlier messages
-
Jochen Roth uploaded patch set 1 12/12/22, 23:29
-
Jochen Roth uploaded patch set 2 12/12/22, 23:30
-
core-ci voted on patch set 2 V -1 12/12/22, 23:39 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34963
-
core-ci voted on patch set 1 V -1 12/12/22, 23:42 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34962
-
Jochen Roth uploaded patch set 3
V -112/13/22, 00:09 -
core-ci voted on patch set 3 V -1 12/13/22, 00:17 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34965
-
Jochen Roth uploaded patch set 4
V -112/13/22, 00:50 -
core-ci voted on patch set 4 V +1 12/13/22, 00:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34966
-
Torben Hansen commented on patch set 4 12/13/22, 05:07
-
Torben Hansen commented on patch set 4 12/13/22, 05:50
SetupCommand.php:504I think it suits better to display the actual requirements of the password policy here. See `PasswordPolicy::getRequirements` which returns an array of all defined password requirements. -
Torben Hansen commented on patch set 4 12/13/22, 05:54
SetupCommand.php:504ReplyOh, I just saw, it is even better to actually display the validation results here. See `PasswordPolicyValidator::getValidationErrors()` -
Jochen Roth uploaded patch set 5
V +112/13/22, 09:13 -
Jochen Roth commented on patch set 5 12/13/22, 09:20
SetupCommand.php:504ReplyDoneSetupDatabaseService.php:265ReplyDone
-
core-ci voted on patch set 5 V +1 12/13/22, 09:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34985
-
Jochen Roth uploaded patch set 6
V +112/13/22, 09:59 -
core-ci voted on patch set 6 V +1 12/13/22, 10:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35013
-
Georg Ringer voted on patch set 6 CR +1 12/14/22, 10:42
-
Benni Mack commented on patch set 6 12/14/22, 11:26
@torben - I think it's worth mentioning as Feature or Important.rst to use this (and that one could also configure this?) -
Torben Hansen commented on patch set 6 12/14/22, 11:31
Reply
@benni - yes, a Feature rst should be included as in https://review.typo3.org/c/Packages/TYPO3.CMS/+/76445/7/typo3/sysext/core/Documentation/Changelog/12.2/Feature-97390-UsePasswordPolicyForPasswordResetInExtfelogin.rst This should make clear, that password policies can be configured globally -
Torben Hansen commented on patch set 6 12/14/22, 19:10
InstallerController.php:534The validation errors must be collected into one FlashMessage, since only one flash message is rendered when the password policy is not fulfilled. Currently, only the last FlashMessage is shown. -
Jochen Roth commented on patch set 6 12/15/22, 00:06
InstallerController.php:534ReplyHmm ... strange. The change in installer.ts should allow to display multiple FlashMessages now. Sorry, i can't reproduce this on my local setup. Maybe the installer.js not update by the browser for some reason? -
Torben Hansen commented on patch set 6 12/15/22, 07:21
InstallerController.php:534ReplySorry, my fault. Browser cache issues. -
Jochen Roth uploaded patch set 7
CR +1V +112/15/22, 07:40 -
Jochen Roth updated the commit message in patch set 8 12/15/22, 07:41
-
Jochen Roth uploaded patch set 9 12/15/22, 07:42
-
Jochen Roth uploaded patch set 10 12/15/22, 07:46
-
core-ci voted on patch set 7 V +1 12/15/22, 07:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35149
-
core-ci voted on patch set 8 V +1 12/15/22, 07:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35150
-
core-ci voted on patch set 9 V +1 12/15/22, 07:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35151
-
core-ci voted on patch set 10 V +1 12/15/22, 07:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35152
-
Benni Mack voted on patch set 10 CR +1 12/15/22, 08:54
-
Torben Hansen voted on patch set 10 V +1 CR +1 12/15/22, 16:21
-
Jochen Roth rebased onto patch set 11
CR +1V +112/17/22, 04:56 -
core-ci voted on patch set 11 V +1 12/17/22, 05:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35210
-
Torben Hansen voted on patch set 11 V +1 CR +1 12/18/22, 17:48
-
Benni Mack commented on patch set 11 12/20/22, 16:56
Reply
Done -
Benni Mack voted on patch set 11 V +2 CR +2 12/20/22, 16:57
-
Benni Mack merged patch set 12 12/20/22, 16:57
SetupDatabaseService.php:265