Review 11.5 Merged

77092[SECURITY] Prohibit TypoScript in form yaml files

Oliver Hader CR +2 V +2 Hard +252 −10 updated 12/13/22, 09:20

Commit message

Only evaluate TypoScript-like instructions like

```
submitButtonLabel = TEXT
submitButtonLabel.value = Bar
```

defined within

`plugin.tx_form.settings.formDefinitionOverrides`
and
`plugin.tx_form.settings.yamlSettingsOverrides`

and **not** within form definition yaml files or
the form setup yaml files.

This is achieved by not searching the entire form
definition or form setup for TypoScript instructions,
but only the actual TypoScript.

Review

  • Code review CR +2 Done
    • Oliver Hader +2
  • Verified V +2 Done
    • Oliver Hader +2

Issues 1

Files 4

Review log 3

  1. Oliver Hader uploaded patch set 1 12/13/22, 09:20

  2. Oliver Hader commented on patch set 1 V +2 CR +2 12/13/22, 09:20

    Auto-approved
  3. Oliver Hader merged patch set 2 12/13/22, 09:20