Review main Merged

7711[BUGFIX] TSConfig for fields with a dot in the name does not work

Kai Richter CR +2 V +2 Hard +318 −6 updated 06/03/13, 20:49

Commit message

This patch enables the use of double quotes in TypoScript setup paths.
Thus, for example, can Extbase field names be separated using quotes in
TSConfig.

Example:

TCEFORM.tt_content.pi_flexform.myext_myplugin.sDEF {
  "settings.fieldOne".config.type = text
  "settings.fieldTwo" = foo
}

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Stefan Neufeind +1
    • Wouter Wolters +1
    • Eric Chavaillaz +1
  • Verified V +2
    • Christian Kuhn +2
    • Stefan Neufeind +1
    • Wouter Wolters +1
    • Eric Chavaillaz +1

Files 2

Review log 61

Show 36 earlier messages
  1. Markus Klein commented on patch set 1 03/25/13, 18:27

    I would prefer that you didn't submit this Which Releases?
  2. Tolleiv Nietsch commented on patch set 2 03/25/13, 18:27

    Please add unit tests for the new method
  3. Steffen Gebert uploaded patch set 2 03/25/13, 18:27

  4. Mr. Jenkins commented on patch set 1 03/25/13, 18:27

  5. Mr. Jenkins commented on patch set 2 03/25/13, 18:27

  6. Christian Kuhn commented on patch set 3 03/25/13, 18:27

    (6 inline comments)
    Rename needed? This is not extbase specific, right? If I understand correctly, this is about sub settings that are delimited with a dot that can not be set currently?
    I'm unsure if we should backport so heavily here Maybe 6.0 or 6.0 and 4.7 are enough? Can this possibly break something?

    class.t3lib_tceforms_flexforms.php:179

    (optional) Since the change affects this method, it would be great if we could have at least a simple and basic test case for this method as well, to show the basic functionality of the method in action.

    class.t3lib_tceforms_flexformsTest.php:3

    whitespace before *

    class.t3lib_tceforms_flexformsTest.php:44

    protected, and should probably be renamed: The third and fourth prameters are specific to the test case below, so the method can probably not re-used for other tests. One solution would be to count the input paramerters, and add all after the second one to invoke.

    class.t3lib_tceforms_flexformsTest.php:59

    Please reformat: 'foo' => array( array(), array(), 'bar' => array( ... ), ); This way the input parameters for the test are below each other.
  7. Mr. Jenkins commented on patch set 3 03/25/13, 18:27

  8. Wouter Wolters commented on patch set 3 03/25/13, 18:27

    Added a unit-test for this.

    class.t3lib_tceforms_flexforms.php:179 Reply

    I'll put it on my TODO list. I'm not yet completly in to Unit-testing. This was my first attempt:-)

    class.t3lib_tceforms_flexformsTest.php:3 Reply

    Done

    class.t3lib_tceforms_flexformsTest.php:44 Reply

    Done

    class.t3lib_tceforms_flexformsTest.php:59 Reply

    Done
  9. Wouter Wolters commented on patch set 3 03/25/13, 18:27

    (4 inline comments)
  10. Wouter Wolters uploaded patch set 3 03/25/13, 18:27

  11. Kai Richter uploaded patch set 5 03/25/13, 18:27

  12. Oliver Hader commented on patch set 6 03/25/13, 18:27

    (1 inline comment)
  13. Oliver Hader commented on patch set 6 03/25/13, 18:27

    If I read the problem description, then it does not sound like particular flexform problem but more TS parser related...
  14. Oliver Hader commented on patch set 6 03/25/13, 18:27

    ... which also affects the possibility to override locallang definitons in TypoScript if the key is e.g. "message.general"
  15. Kai Richter uploaded patch set 6 03/25/13, 18:27

  16. Oliver Hader commented on patch set 7 03/25/13, 18:27

    I would prefer that you didn't submit this As mentioned in earlier comments, I'd like to see that fixed in the parser not in the specific disposal in a combination of flexforms and TypoScript only... Thus -1 for the time being
  17. Steffen Ritter commented on patch set 7 03/25/13, 18:27

    Verified; Looks good to me, but someone else must approve unit test executed, no manual test
  18. Kai Richter uploaded patch set 7 03/25/13, 18:27

  19. Kai Richter uploaded patch set 8 03/25/13, 18:27

  20. Kai Richter uploaded patch set 9 03/25/13, 18:27

  21. Stefan Neufeind commented on patch set 10 03/25/13, 18:27

    another testcase for this maybe?
  22. Stefan Neufeind commented on patch set 10 03/25/13, 18:27

    @Kai: I meant really a unit-test :-)
  23. Kai Richter uploaded patch set 10 03/25/13, 18:27

  24. Kai Richter commented on patch set 10 03/25/13, 18:27

    @Stefan: plugin.tx_myext._LOCAL_LANG.de."some.error.message"
  25. Christian Kuhn commented on patch set 11 03/25/13, 18:27

    (2 inline comments)
  26. Kai Richter uploaded patch set 11 03/25/13, 18:27

  27. Oliver Hader commented on patch set 12 03/25/13, 18:27

    I would prefer that you didn't submit this
  28. Oliver Hader uploaded patch set 13 03/25/13, 18:27

  29. Oliver Hader commented on patch set 13 03/25/13, 18:27

    I would prefer that you didn't submit this See the unit tests, which is also the reason why we don't want the situation to be like the current patch reflects. Unfortunately I don't have time to fix this for 6.0. However, something really essential in the parser to handle/substitute the quotes is missing. At least, we are on the right track here...
  30. Kai Richter uploaded patch set 12 03/25/13, 18:27

  31. Kai Richter uploaded patch set 14 03/25/13, 18:27

  32. Kai Richter uploaded patch set 15 03/25/13, 18:27

  33. Kai Richter uploaded patch set 16 03/25/13, 18:27

  34. Stefan Neufeind commented on patch set 17 03/25/13, 18:27

    Looks good to me, but someone else must approve
  35. Kai Richter uploaded patch set 17 03/25/13, 18:27

  36. Kai Richter commented on patch set 17 03/25/13, 18:27

    All unit tests pass now.
  1. Eric Chavaillaz commented on patch set 17 03/25/13, 18:27

    Verified; Looks good to me, but someone else must approve
  2. Mr. Jenkins commented on patch set 4 03/25/13, 18:27

  3. Mr. Jenkins commented on patch set 5 03/25/13, 18:27

    Fails; I would prefer that you didn't submit this Build Failed https://ci.typo3.org/job/typo3-v4-core-gerrit/6404/ : FAILURE
  4. Mr. Jenkins commented on patch set 6 03/25/13, 18:27

  5. Mr. Jenkins commented on patch set 7 03/25/13, 18:27

  6. Mr. Jenkins commented on patch set 8 03/25/13, 18:27

    Fails; I would prefer that you didn't submit this Build Failed https://ci.typo3.org/job/typo3-v4-core-gerrit/6681/ : FAILURE
  7. Mr. Jenkins commented on patch set 9 03/25/13, 18:27

    Fails; I would prefer that you didn't submit this Build Failed https://ci.typo3.org/job/typo3-v4-core-gerrit/6682/ : FAILURE
  8. Mr. Jenkins commented on patch set 10 03/25/13, 18:27

  9. Mr. Jenkins commented on patch set 11 03/25/13, 18:27

    Fails; I would prefer that you didn't submit this Build Failed https://ci.typo3.org/job/typo3-v4-core-gerrit/6752/ : FAILURE
  10. Mr. Jenkins commented on patch set 12 03/25/13, 18:27

  11. Mr. Jenkins commented on patch set 13 03/25/13, 18:27

  12. Mr. Jenkins commented on patch set 14 03/25/13, 18:27

    Fails; I would prefer that you didn't submit this Build Failed https://ci.typo3.org/job/typo3-v4-core-gerrit/6872/ : FAILURE
  13. Mr. Jenkins commented on patch set 15 03/25/13, 18:27

    Fails; I would prefer that you didn't submit this Build Failed https://ci.typo3.org/job/typo3-v4-core-gerrit/6873/ : FAILURE
  14. Mr. Jenkins commented on patch set 16 03/25/13, 18:27

  15. Mr. Jenkins commented on patch set 17 03/25/13, 18:27

  16. Wouter Wolters uploaded patch set 4 03/25/13, 18:27

  17. Wouter Wolters voted on patch set 6 V 0 03/25/13, 18:27

  18. Stefan Neufeind commented on patch set 18 03/25/13, 18:27

    Verified; Looks good to me, but someone else must approve That preg-thing naturally is a bit crazy to "review". But I think I understood it right. And it seems to work for me.
  19. Eric Chavaillaz commented on patch set 18 03/25/13, 18:27

    Verified; Looks good to me, but someone else must approve
  20. Mr. Jenkins commented on patch set 18 03/25/13, 18:27

  21. Wouter Wolters uploaded patch set 18 03/25/13, 18:27

  22. Wouter Wolters commented on patch set 18 03/25/13, 18:27

    Verified; Looks good to me, but someone else must approve
  23. Christian Kuhn commented on patch set 18 V 0 03/25/13, 18:27

    by team member; Looks good to me, approved Ok. We've discussed this multiple times now ... the solution is for now pretty convenient and at least solves the real problem. For 6.1, this would now be the right time to get it in. I'm not 100% sure this patch doesn't introduce some weird side effects, so better get that in now and see if something pops up before final. ... So: Merged for now, but this patch would be a candidate for a revert if something strange happens.
  24. Christian Kuhn merged patch set 19 03/25/13, 18:27

  25. Christian Kuhn commented on patch set 19 03/25/13, 20:42

    Reverted This patchset was reverted in change: I8f7147466ffae727b131143c4d860940a8b6796b

    TypoScriptParserTest.php:28

    ext:core tests should extend core base test case, not extbase base test case, if there is no special reason to do otherwise.

    TypoScriptParserTest.php:45

    both tests *could* be merged in one test using a data provider, as optional improvement. This would also make it easier to add more cases is needed.