Review 12.1 Merged

77114[TASK] Add HTTP host header injection check to reports module

Oliver Hader CR +2 V +2 Normal +122 −2 updated 12/13/22, 11:33

Commit message

In case the web server scenario is not properly configured to deny
HTTP host header injection, and the trustedHostsPattern is not explicit
enough, a corresponding check in the reports module will issue
an error message like

* HTTP_HOST contained unexpected "a0a3aa2f59.random.example.org"
* SERVER_NAME contained unexpected "a0a3aa2f59.random.example.org"

Using the configuration directive `UseCanonicalName On` for Apache
web server environments mitigates the risk.

Review

  • Code review CR +2 Done
    • Oliver Hader +2
  • Verified V +2 Done
    • Oliver Hader +2

Issues 1

Files 7

Review log 57

  1. Oliver Hader uploaded patch set 1 12/13/22, 11:10

  2. core-ci voted on patch set 1 V -1 12/13/22, 11:14 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35027

  3. Oliver Hader rebased onto patch set 2 V -1 12/13/22, 11:18

  4. core-ci voted on patch set 2 V -1 12/13/22, 11:29 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35032

  5. Oliver Hader wrote 12/13/22, 11:33

    Removed Verified-1 by core-ci
  6. Oliver Hader voted on patch set 2 V +2 CR +2 12/13/22, 11:33

  7. Oliver Hader merged patch set 3 12/13/22, 11:33