77121[TASK] Convert FrontendUserAuthenticationTest partially to functional
Commit message
Review
-
Code review CR +2 Done
- Nikita Hovratov +2
- Torben Hansen +1
- Benni Mack +1
-
Verified V +2 Done
- Nikita Hovratov +2
- Oliver Klee +1
- Torben Hansen +1
- Benni Mack +1
- core-ci +1 CI
Issues 1
Files 6
- typo3/sysext/frontend/Tests/Functional/Authentication/Fixtures/fe_sessions_empty.csvnew+2 −0
- typo3/sysext/frontend/Tests/Functional/Authentication/Fixtures/fe_sessions_filled.csvnew+3 −0
- typo3/sysext/frontend/Tests/Functional/Authentication/Fixtures/fe_users.csvnew+6 −0
- typo3/sysext/frontend/Tests/Functional/Authentication/FrontendUserAuthenticationTest.phpnew+98 −0
- typo3/sysext/frontend/Tests/Functional/Fixtures/TypoScript/page.typoscriptnew+3 −0
- typo3/sysext/frontend/Tests/Unit/Authentication/FrontendUserAuthenticationTest.php+20 −236
Review log 913
-
Nikita Hovratov uploaded patch set 1 12/13/22, 22:45
-
core-ci voted on patch set 1 V -1 12/13/22, 22:57 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35070
-
Nikita Hovratov uploaded patch set 2
V -112/13/22, 22:57 -
core-ci voted on patch set 2 V +1 12/13/22, 23:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35071
-
Nikita Hovratov uploaded patch set 3
V +112/14/22, 17:57 -
core-ci voted on patch set 3 V +1 12/14/22, 18:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35116
-
Nikita Hovratov rebased onto patch set 4
V +112/15/22, 21:27 -
core-ci voted on patch set 4 V +1 12/15/22, 21:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35179
-
Benni Mack commented on patch set 4 V +1 CR +1 12/19/22, 11:56
this one is a good one, looking forward to migrating the other tests to functionals as well, this will be really important for further testing session handling. -
Oliver Klee voted on patch set 4 V +1 12/19/22, 17:11
-
Torben Hansen commented on patch set 4 V +1 CR +1 12/22/22, 14:39
Nice job! -
Nikita Hovratov commented on patch set 4 V +2 CR +2 12/22/22, 14:44
Reply
thanks! -
Nikita Hovratov merged patch set 5 12/22/22, 14:44