Review main Merged

77126[TASK] Avoid empty ul tag if no submodules are available

Georg Ringer CR +2 V +2 Easy +3 −1 updated 12/14/22, 15:04

Commit message

If no submodule are available, the ul tag around should not be rendered.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Oliver Klee +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 78

  1. Georg Ringer uploaded patch set 1 12/14/22, 08:58

  2. Georg Ringer commented on patch set 1 12/14/22, 08:58

    This change is ready for review.
  3. core-ci voted on patch set 1 V +1 12/14/22, 09:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35084

  4. Oliver Klee voted on patch set 1 CR +1 12/14/22, 09:37

  5. Oli Bartsch voted on patch set 1 V +1 CR +1 12/14/22, 09:42

  6. Andreas Kienast voted on patch set 1 V +1 CR +1 12/14/22, 14:26

  7. Oli Bartsch voted on patch set 1 V +2 CR +2 12/14/22, 15:04

  8. Oli Bartsch merged patch set 2 12/14/22, 15:04