Review 11.5 Merged

77153[BUGFIX] Catch any transfer exception in HTTP host header check

Oliver Hader CR +2 V +2 Easy +12 −2 updated 12/15/22, 09:58

Commit message

ServerResponseCheck triggers a HTTP host header check which is
expected to fail. The more generic TransferException is used to
catch any other failed request, not only those with 4xx or 5xx
HTTP status codes. Besides that, TLS certificates shall not be
verified, and HTTP location redirects not be followed.

Review

  • Code review CR +2 Done
    • Oliver Hader +2
  • Verified V +2 Done
    • Oliver Hader +2
    • core-ci +1 CI

Issues 1

Files 1

Review log 69

  1. Oliver Hader uploaded patch set 1 12/14/22, 13:49

  2. core-ci voted on patch set 1 V +1 12/14/22, 13:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35104

  3. Oliver Hader uploaded patch set 2 V +1 12/14/22, 17:45

  4. core-ci voted on patch set 2 V +1 12/14/22, 17:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35114

  5. Oliver Hader uploaded patch set 3 V +1 12/14/22, 21:36

  6. Oliver Hader uploaded patch set 4 12/14/22, 21:40

  7. core-ci voted on patch set 4 V +1 12/14/22, 22:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35130

  8. Oliver Hader commented on patch set 4 V +2 CR +2 12/15/22, 09:58

    This change is ready for review.
  9. Oliver Hader merged patch set 5 12/15/22, 09:58