77159[BUGFIX] Fix absolute backend URL generation in frontend context
Commit message
Review
-
Code review CR +2 Done
- Benjamin Franzke +2
- Oliver Hader +1
- Benni Mack +1
-
Verified V +2 Done
- Benjamin Franzke +2
- Oliver Hader +1
- Benni Mack +1
- core-ci +1 CI
Issues 3
Files 6
- typo3/sysext/backend/Classes/Routing/UriBuilder.php+2 −2
- typo3/sysext/backend/Tests/Functional/Template/Components/Buttons/Action/ShortcutButtonTest.php+8 −0
- typo3/sysext/backend/Tests/Functional/Template/Fixtures/RecordListCopyToClipboard.html+1 −1
- typo3/sysext/backend/Tests/Functional/Template/Fixtures/RecordListSingleTableCopyToClipboard.html+1 −1
- typo3/sysext/backend/Tests/Functional/Template/Fixtures/SpecialRouteIdentifierWithArgumentsCopyToClipboard.html+1 −1
- typo3/sysext/extbase/Tests/Unit/Mvc/Web/Routing/UriBuilderTest.php3+34 −1
Review log 1723
-
Benjamin Franzke uploaded patch set 1 12/14/22, 21:29
-
Oliver Hader updated the commit message in patch set 2 12/14/22, 21:31
-
Oliver Hader commented on patch set 2 12/14/22, 21:32
Added `12.1` to `Releases` line -
Oliver Hader updated the commit message in patch set 3 12/14/22, 21:33
-
Oliver Hader commented on patch set 3 12/14/22, 21:34
Removed `12.1` again, https://review.typo3.org/c/Packages/TYPO3.CMS/+/76865 was integrated in `12.1.0`. -
core-ci voted on patch set 1 V -1 12/14/22, 21:37 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35122
-
core-ci voted on patch set 3 V -1 12/14/22, 22:01 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35125
-
Benjamin Franzke uploaded patch set 4
V -112/15/22, 06:26 -
core-ci voted on patch set 4 V -1 12/15/22, 06:34 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35146
-
Benjamin Franzke uploaded patch set 5
V -112/15/22, 06:39 -
core-ci voted on patch set 5 V +1 12/15/22, 06:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35147
-
Oliver Hader commented on patch set 5 12/15/22, 08:14
UriBuilderTest.php:375This one looks strange, actually `/typo3/index.php` seemed to be correct. Wasn't it? Maybe it's related to `getRequestWithRouteAttribute` using `new Uri('')`? -
Benjamin Franzke commented on patch set 5 12/15/22, 08:24
UriBuilderTest.php:375ReplyI agree, ideally we'd test both cases. I actually just copied that 1:1 from this change in v12 https://review.typo3.org/c/Packages/TYPO3.CMS/+/75620/16/typo3/sysext/extbase/Tests/Unit/Mvc/Web/Routing/UriBuilderTest.php#380 -
Benjamin Franzke uploaded patch set 6
V +112/15/22, 08:42 -
Benjamin Franzke commented on patch set 6 12/15/22, 08:42
UriBuilderTest.php:375ReplyAdapted to test both cases. -
Oliver Hader voted on patch set 6 V +1 CR +1 12/15/22, 08:47
-
core-ci voted on patch set 6 V -1 12/15/22, 08:51 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35153
-
Benjamin Franzke uploaded patch set 7
CR +1V +112/15/22, 08:51 -
Oliver Hader voted on patch set 7 V +1 CR +1 12/15/22, 08:56
-
core-ci voted on patch set 7 V +1 12/15/22, 09:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35155
-
Benni Mack voted on patch set 7 V +1 CR +1 12/15/22, 10:02
-
Benjamin Franzke voted on patch set 7 V +2 CR +2 12/15/22, 10:03
-
Benjamin Franzke merged patch set 8 12/15/22, 10:03