Review main Merged

77162[BUGFIX] Use fallback method to get dbname

Jochen Roth CR +2 V +2 Easy +5 −5 updated 12/15/22, 09:52

Commit message

The fallback chain for determination of the
dbname in the SetupCommand is now using the
dedicated fallback method to gather values
from env -> cli option.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Torben Hansen +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Torben Hansen +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 79

  1. Jochen Roth uploaded patch set 1 12/15/22, 01:41

  2. core-ci voted on patch set 1 V +1 12/15/22, 01:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35136

  3. Torben Hansen voted on patch set 1 V +1 CR +1 12/15/22, 07:30

  4. Oli Bartsch updated the commit message in patch set 2 CR +1 V +1 12/15/22, 09:20

  5. Oli Bartsch voted on patch set 2 V +1 CR +1 12/15/22, 09:21

  6. core-ci voted on patch set 2 V +1 12/15/22, 09:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35158

  7. Torben Hansen voted on patch set 2 V +1 CR +1 12/15/22, 09:30

  8. Oli Bartsch voted on patch set 2 V +2 CR +2 12/15/22, 09:52

  9. Oli Bartsch merged patch set 3 12/15/22, 09:52