Review main Merged

77176[BUGFIX] Make SITE: placeholder work in foreign_selector

David Blatter CR +2 V +2 Easy +1 −0 updated 01/20/23, 12:52

Commit message

A tca column with a SITE: placeholder inside the
foreign_table_where config whould not work when used as a
foreign_selector in an irre. To make it work, this change
adds the resolved site from the parent context.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1113

  1. David Blatter uploaded patch set 1 12/15/22, 21:36

  2. core-ci voted on patch set 1 V +1 12/15/22, 21:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35181

  3. Georg Ringer voted on patch set 1 V +1 CR +1 12/17/22, 20:02

  4. Jörg Bösche voted on patch set 1 CR +1 01/20/23, 08:25

  5. Christian Kuhn commented on patch set 1 CR -1 01/20/23, 11:16

    on it. need to check if it works in ajax scenarios ...
  6. Christian Kuhn voted on patch set 1 V +2 CR +2 01/20/23, 11:27

  7. Christian Kuhn commented on patch set 1 V 0 CR 0 01/20/23, 11:27

    will push again to fix relation chain.
  8. Christian Kuhn uploaded patch set 2 CR +1 V +1 01/20/23, 11:28

  9. Christian Kuhn voted on patch set 2 V +1 CR +1 01/20/23, 11:28

  10. core-ci voted on patch set 2 V +1 01/20/23, 11:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36340

  11. Stefan Bürk voted on patch set 2 V +1 CR +1 01/20/23, 12:47

  12. Christian Kuhn voted on patch set 2 V +2 CR +2 01/20/23, 12:52

  13. Christian Kuhn merged patch set 3 01/20/23, 12:52