Review main Merged

77195[FEATURE] Add new redirect `PageTypeSource` source type implementation

Stefan Froemken CR +2 V +2 Hard +769 −8 updated 03/27/23, 14:53

Commit message

It's possible that project instances are configured to use
RouteEnhancers and RouteDecorators, e.g. PageTypeSuffix
RouteDecorater with a suffix for page type "0" (zero) like
".html". Until now, only the slug-field value has been used
as source path for auto created redirects, which neglected to
respect these route configuration possibilities. That means
that a proper redirect hasn't been create if for e.g. the
".html" suffix has been configured for page type "0".

Since #99188 introduced the "SlugRedirectChangeItemCreatedEvent"
it's possible to add further source types, for which redirects
are created.

This change provides the "PageTypeSource" as new generic source
type for page type based sources. The TYPO3 core adds a listener
to build an URI with page type "0" and adds this to the current
change item as source. This added `PageTypeSource` will replace
the `PlainSlugReplacementSource` if the source host and path
are the same - it overrules it to avoid duplicate redirects.
That means, if both are providing different source information
both are kept and two different redirects are created.

Extension authors can now use the new PageTypeSource type to
provide additional sources for other page types registering
a custom "SlugRedirectChangeItemCreatedEvent" listener - or
remove the "PlainSlugReplacementSource" if needed. With this
event based solution configuration options are kept simple.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Stefan Froemken +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Stefan Froemken +1
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 2

Files 8

Review log 6897

Show 4872 earlier messages
  1. Stefan Froemken uploaded patch set 1 12/21/22, 12:37

  2. core-ci voted on patch set 1 V -1 12/21/22, 12:51 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35268

  3. Stefan Froemken uploaded patch set 2 V -1 12/21/22, 13:37

  4. core-ci voted on patch set 2 V -1 12/21/22, 13:48 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35270

  5. Stefan Froemken uploaded patch set 3 V -1 12/21/22, 15:10

  6. core-ci voted on patch set 3 V -1 12/21/22, 15:21 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35274

  7. Benni Mack commented on patch set 3 12/21/22, 16:03

    reason why we want this into 11.4 and not in 11.5 ? :)
  8. Stefan Froemken uploaded patch set 4 V -1 12/21/22, 16:12

  9. core-ci voted on patch set 4 V -1 12/21/22, 16:22 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35279

  10. Stefan Froemken uploaded patch set 5 V -1 12/21/22, 16:27

  11. core-ci voted on patch set 5 V -1 12/21/22, 16:45 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35280

  12. Stefan Froemken uploaded patch set 6 V -1 12/21/22, 16:57

  13. core-ci voted on patch set 6 V -1 12/21/22, 17:05 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35282

  14. Stefan Bürk commented on patch set 5 12/21/22, 17:08

    Reply

    Would cut 11.5 anyway. First, the source collection thing is not existent in 11.5, secondly we can debate for and back if this is a real bugfix. In the end it is a dramasticly change in behaviour for a backport. Generally we could do here two things for main: * implement a event on the prehook so instances can create custom sources which should be created as a redirect (that's already on my todo list) * implement a second redirect beside the plainslubreplacement redirect which is added to the source collection directly (at beast combined with a feature toggle ?) Does not make much sense to only suppoert "page typeNum 0" - combined with the array people can define/hook and manipulate for which sources redirect should be created. and eventually adding routeEnhacer aware source paths or multiple pageTypes or arguments.

    PlainSlugReplacementRedirectSource.php:29

    That should be the "path" .. for other types (PageTypeNum Bases sources) a new class should be crated, implementing "RedirectSourceInterface". There the "path" is the "$decoratedPath" .. this this change is not needed.
  15. Stefan Bürk voted on patch set 6 CR -2 12/21/22, 17:08

  16. Stefan Bürk voted on patch set 6 CR -1 12/21/22, 17:08

  17. Stefan Bürk commented on patch set 6 12/21/22, 18:41

    will take over, talked with Stefan Froemken.
  18. Stefan Bürk uploaded patch set 7 CR -1 V -1 12/21/22, 20:04

  19. Stefan Bürk commented on patch set 7 CR -2 12/21/22, 20:06

    Pushed first changes, will take care of pre-patch (bugfix) extraction and finishing this as feature with events and additional tests. Thus the -2 for now.
  20. core-ci voted on patch set 7 V -1 12/21/22, 20:12 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35283

  21. Benni Mack wrote 12/23/22, 10:22

    Removed cc Benni Mack.
  22. Stefan Bürk uploaded patch set 8 V -1 01/13/23, 16:31

    Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR is:MIN")
  23. core-ci voted on patch set 8 V +1 01/13/23, 16:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35772

  24. Stefan Bürk rebased onto patch set 9 V +1 01/16/23, 21:43

    Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR is:MIN")
  25. core-ci voted on patch set 9 V +1 01/16/23, 22:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35896

  26. Stefan Bürk uploaded patch set 10 V +1 01/30/23, 03:01

    Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR is:MIN")
  27. Stefan Bürk updated the commit message in patch set 11 01/30/23, 03:18

    Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR is:MIN")
  28. core-ci voted on patch set 10 V -1 01/30/23, 03:20 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36739

  29. Stefan Bürk uploaded patch set 12 01/30/23, 03:22

    Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR is:MIN")
  30. Stefan Bürk uploaded patch set 13 01/30/23, 03:23

    Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR is:MIN")
  31. core-ci voted on patch set 12 V -1 01/30/23, 03:34 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36742

  32. core-ci voted on patch set 11 V -1 01/30/23, 03:35 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36741

  33. core-ci voted on patch set 13 V +1 01/30/23, 03:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36743

  34. Stefan Bürk commented on patch set 13 CR -2 01/30/23, 07:24

    Extracted pre-patch for the event and basic stuff: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77633
  35. Stefan Bürk rebased onto patch set 14 V +1 01/30/23, 17:46

    Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR is:MIN")
  36. core-ci voted on patch set 14 V +1 01/30/23, 18:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36785

  37. Stefan Bürk uploaded patch set 15 V +1 02/03/23, 11:19

    Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR is:MIN")
  38. Stefan Bürk voted on patch set 15 CR 0 02/03/23, 11:20

  39. Stefan Bürk commented on patch set 15 02/03/23, 11:34

    Reply

    Done

    Reply

    Done

    PlainSlugReplacementRedirectSource.php:29 Reply

    Done
  40. Stefan Bürk commented on patch set 15 02/03/23, 11:34

    Reply

    Done
  41. core-ci voted on patch set 15 V -1 02/03/23, 11:38 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36976

  42. Stefan Bürk uploaded patch set 16 V -1 02/03/23, 14:24

  43. Stefan Bürk uploaded patch set 17 02/03/23, 15:00

  44. Stefan Bürk updated the commit message in patch set 18 02/03/23, 15:01

  45. Stefan Bürk updated the commit message in patch set 19 02/03/23, 15:03

  46. core-ci voted on patch set 16 V -1 02/03/23, 15:04 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36990

  47. core-ci voted on patch set 19 V +1 02/03/23, 15:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36995

  48. Stefan Bürk uploaded patch set 20 V +1 02/05/23, 17:46

  49. Stefan Bürk updated the commit message in patch set 21 02/05/23, 17:47

  50. core-ci voted on patch set 20 V +1 02/05/23, 17:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37122

  51. core-ci voted on patch set 21 V +1 02/05/23, 17:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37123

  52. Stefan Bürk commented on patch set 22 V +1 02/05/23, 19:57

    Published edit on patch set 21.
  53. core-ci voted on patch set 22 V +1 02/05/23, 20:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37131

  54. Benni Mack commented on patch set 23 V +1 02/08/23, 07:53

    Published edit on patch set 22.
  55. core-ci voted on patch set 23 V +1 02/08/23, 08:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37333

  56. Stefan Froemken commented on patch set 23 CR -1 02/13/23, 07:50

    Feature-99746-NewPSR-14SlugRedirectChangeItemCreatedEvent.rst:64

    THX for taking care of that part

    Feature-94499-ImplementAddPageTypeZeroSourceEventListener.rst:28

    an

    Feature-94499-ProvideAdditionalPageTypeSourceAuto-createRedirectSourceType.rst:76

    space

    Feature-94499-ProvideAdditionalPageTypeSourceAuto-createRedirectSourceType.rst:115

    space

    Feature-94499-ProvideAdditionalPageTypeSourceAuto-createRedirectSourceType.rst:176

    I don't understand that sentence.

    Feature-94499-ProvideAdditionalPageTypeSourceAuto-createRedirectSourceType.rst:178

    an

    AddPlainSlugReplacementSourceTest.php:46

    I expected something like "resetted". I'm just holding my hands in front of... 😄
  57. Stefan Bürk uploaded patch set 24 CR -1 V +1 02/23/23, 11:12

  58. Stefan Bürk commented on patch set 24 02/23/23, 11:12

    Feature-94499-ImplementAddPageTypeZeroSourceEventListener.rst:28 Reply

    Done

    Feature-94499-ProvideAdditionalPageTypeSourceAuto-createRedirectSourceType.rst:76 Reply

    Done

    Feature-94499-ProvideAdditionalPageTypeSourceAuto-createRedirectSourceType.rst:115 Reply

    Done

    Feature-94499-ProvideAdditionalPageTypeSourceAuto-createRedirectSourceType.rst:176 Reply

    Ack. Hope the changed sentence makes more sense.

    Feature-94499-ProvideAdditionalPageTypeSourceAuto-createRedirectSourceType.rst:178 Reply

    Done

    AddPlainSlugReplacementSourceTest.php:46 Reply

    Good 😎 - anyway, changed.
  59. core-ci voted on patch set 24 V +1 02/23/23, 11:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38010

  60. Sybille Peters commented on patch set 24 V -1 02/25/23, 13:01

    With initial tests with the patch applied, 2 redirects are created, one with the routeEnhancer (html), one without: 1. Source Path= /html/page-one-modified 2. Source Path = /html/page-one-modified.html It is not entirely clear to me (from the commit message), why it was implemented this way. The first redirect is unnecessary. Maybe this is just a misunderstanding on my part. Apart from that it is great to get this much anticipated change! I used the configuration from the issue: routeEnhancers: PageTypeSuffix: type: PageType default: '.html' map: '.html': 0
  61. Sybille Peters updated the commit message in patch set 25 V +1 02/25/23, 13:39

  62. Sybille Peters uploaded patch set 26 02/25/23, 13:42

  63. Sybille Peters commented on patch set 25 V -1 02/25/23, 13:43

    > a growing to a comples set I don't know what this means. complex?

    Feature-94499-ImplementAddPageTypeZeroSourceEventListener.rst:16

    > is build => is built

    Feature-94499-ImplementAddPageTypeZeroSourceEventListener.rst:34

    > page tye => "page type"

    Feature-94499-ProvideAdditionalPageTypeSourceAuto-createRedirectSourceType.rst:19

    > a event => an event

    Feature-94499-ProvideAdditionalPageTypeSourceAuto-createRedirectSourceType.rst:28

    > features following => features the following
  64. Sybille Peters commented on patch set 26 02/25/23, 13:45

    Feature-94499-ImplementAddPageTypeZeroSourceEventListener.rst:35

    It is not entirely clear to me, why it was implemented this way. The redirect without the suffix is unnecessary (page type 0 is default).
  65. core-ci voted on patch set 25 V +1 02/25/23, 13:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38094

  66. core-ci voted on patch set 26 V +1 02/25/23, 13:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38095

  67. Stefan Bürk commented on patch set 26 02/26/23, 01:55

    Reply

    Nope, thay are "not the same". If they were the same, it would be only one redirect. PageType 0 suffix is not enforced. Pages are retrievable by them also. And here we have the "multiple use-case paradoxon" - on the one side we have the "only suffix should survive" and on the other "yipi, we need both of 'em". And with the general line along this and other changes, I tried to avoid introducing dozen of configuration options where no one could really say what should be done in which constellation. Therefore, if really needed and PageType 0 has a suffix or other things configured resulting in another source than the "raw slug field value" along with site/siteLanguage base - integrators/developers can register a event listener and decide what to do. If it should be only for a subtree, special pages, special doktypes (you name it !) and remove the `PlainSlugReplacementSource` type if needed. That's already described in the FEATURE introducing that event https://docs.typo3.org/c/typo3/cms-core/main/en-us/Changelog/12.2/Feature-99746-NewPSR-14SlugRedirectChangeItemCreatedEvent.html Here, we introduce additional source type from core side as "page type related" public source type, which can be used. Still, custom source types can be used. It's on the plan to add a chapter to the ext:redirects documentation to provide this and other events in the pipeline and describe possibilites and complexer use-cases more detailed. To answer some questions. However, having it startet in the patches would block them cross over as no one knows in which order they would be reviewed, polished and merged.

    Feature-94499-ImplementAddPageTypeZeroSourceEventListener.rst:35 Reply

    Yes, you are right - partly. Pages are still resolvalbe with the pure slug, even if PageType 0 has a suffix configured. And some are using this to dual mode by intend. Redirect should match for the slug without the suffix also. If not needed, it can be removed with a simple event listener and a corresponding check. See other comment for more detailed answer.
  68. Sybille Peters commented on patch set 26 02/26/23, 07:07

    Feature-94499-ImplementAddPageTypeZeroSourceEventListener.rst:35 Reply

    (1) Still think it might be better for most use cases to not have 2 redirects with page type 0 (if page type route enhancer is active). You can configure it with the event listener, but that would be more something for edge cases. What you could (maybe?) do is pass the RedirectSourceCollection but for each source have flag to set if the source is used or not used, and by default not use the source without route enhancer for page type 0. I am really not familiar with the source code in that area, this is just something I noticed which might come up "in the field" (and would be more difficult to change later). (2) Suggestion to add this here (because others might ask the same questions): ------- This behaviour can be modified by adding an event listener for :ref:`SlugRedirectChangeItemCreatedEvent <feature-99746-1675059434>`. .. todo:: Add link to main documentation or EXT:redirects once this contains more examples for the new events. The documentation will later be modified to include more examples.
  69. Simon Schaufelberger commented on patch set 26 02/26/23, 09:57

    AddPageTypeZeroSource.php:73

    why is clone used here?
  70. Stefan Bürk uploaded patch set 27 V +1 02/26/23, 14:16

  71. Stefan Bürk commented on patch set 27 02/26/23, 14:22

    Reply

    "complex" should that have been. Anyway, removed the half sentence now. Kepp the "kept simple" simple.

    Feature-94499-ImplementAddPageTypeZeroSourceEventListener.rst:35 Reply

    I hae done a mix .. added (2) under "Impact", slightly different. Main reason, because I also enhanced the "Description" section with a explanation and additional with a example listener do remove the plain slug if needed. I hope this helps to avoid confusion for others and solves it for you. Thanks for pointing this out.

    AddPageTypeZeroSource.php:73 Reply

    Copy&Paste issue. removed the clone, unneded here. Thanks.
  72. Sybille Peters commented on patch set 27 CR +1 02/26/23, 14:44

    Feature-94499-ImplementAddPageTypeZeroSourceEventListener.rst:35 Reply

    Perfect! Thanks.
  1. core-ci voted on patch set 27 V +1 02/26/23, 14:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38113

  2. Simon Schaufelberger commented on patch set 27 02/26/23, 21:41

    AddPageTypeZeroSourceTest.php:167

    then this clone can probably also be removed

    AddPageTypeZeroSourceTest.php:177

    2 spaces before new
  3. Stefan Bürk uploaded patch set 28 CR +1 V +1 02/26/23, 21:47

  4. Stefan Bürk commented on patch set 27 02/26/23, 21:47

    AddPageTypeZeroSourceTest.php:167 Reply

    ack, done.

    AddPageTypeZeroSourceTest.php:177 Reply

    Done
  5. core-ci voted on patch set 28 V +1 02/26/23, 21:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38134

  6. Stefan Froemken commented on patch set 28 CR -1 03/10/23, 11:21

    Feature-94499-ImplementAddPageTypeZeroSourceEventListener.rst:17

    RouteEnhancers

    Feature-94499-ImplementAddPageTypeZeroSourceEventListener.rst:49

    know

    Feature-94499-ImplementAddPageTypeZeroSourceEventListener.rst:64

    move into next row. Remove empty row

    Feature-94499-ProvideAdditionalPageTypeSourceAuto-createRedirectSourceType.rst:70

    Move into next line. Remove empty lines

    Feature-94499-ProvideAdditionalPageTypeSourceAuto-createRedirectSourceType.rst:72

    no leading comma needed if array is single line
  7. Oliver Klee commented on patch set 28 03/10/23, 16:03

    Can we mark any of the new classes/methods as `@internal` so we can refactor/remove them later at will?
  8. Stefan Bürk uploaded patch set 29 CR -1 V +1 03/17/23, 06:26

  9. Stefan Bürk commented on patch set 29 03/17/23, 06:27

    Reply

    Done for the event listener `AddPageTypeZeroSource`, albit it has been final and thus not public api per se. The rest is either only test classes and therefor internal per design - or in case of `PageTypeSource` it is the part of the feature to provide it. Extension developer should be able to use it, an @internal mark would make this an absurdum.

    Feature-94499-ImplementAddPageTypeZeroSourceEventListener.rst:17 Reply

    Done

    Feature-94499-ImplementAddPageTypeZeroSourceEventListener.rst:49 Reply

    Done

    Feature-94499-ImplementAddPageTypeZeroSourceEventListener.rst:64 Reply

    Done

    Feature-94499-ProvideAdditionalPageTypeSourceAuto-createRedirectSourceType.rst:70 Reply

    Done

    Feature-94499-ProvideAdditionalPageTypeSourceAuto-createRedirectSourceType.rst:72 Reply

    tailing, not leading - but ack. done.
  10. core-ci voted on patch set 29 V +1 03/17/23, 06:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39098

  11. Stefan Froemken commented on patch set 29 03/17/23, 09:53

    Feature-94499-ImplementAddPageTypeZeroSourceEventListener.rst:59

    use statement for TYPO3\CMS\Redirects\Event\SlugRedirectChangeItemCreatedEvent missing

    Feature-94499-ImplementAddPageTypeZeroSourceEventListener.rst:100

    This class does not exists. Maybe you mean PlainSlugReplacementRedirectSource

    Feature-94499-ImplementAddPageTypeZeroSourceEventListener.rst:105

    At that point $source must be of type PageTypeSource, but return value expects PlainSlugReplacementRedirectSource
  12. Stefan Froemken commented on patch set 29 CR -1 03/17/23, 10:29

    I have tested each of your EventListeners. After correcting them your patch works pretty good.

    Feature-94499-ImplementAddPageTypeZeroSourceEventListener.rst:84

    We can add "static fn" here

    Feature-94499-ProvideAdditionalPageTypeSourceAuto-createRedirectSourceType.rst:120

    instanceof

    Feature-94499-ProvideAdditionalPageTypeSourceAuto-createRedirectSourceType.rst:121

    $pageTypeSource

    Feature-94499-ProvideAdditionalPageTypeSourceAuto-createRedirectSourceType.rst:121

    missing &&

    Feature-94499-ProvideAdditionalPageTypeSourceAuto-createRedirectSourceType.rst:122

    $pageTypeSource

    Feature-94499-ProvideAdditionalPageTypeSourceAuto-createRedirectSourceType.rst:122

    getSource does not exist. Maybe getPath()?

    Feature-94499-ProvideAdditionalPageTypeSourceAuto-createRedirectSourceType.rst:122

    getSource does not exist. Maybe getPath()?

    Feature-94499-ProvideAdditionalPageTypeSourceAuto-createRedirectSourceType.rst:122

    missing &&
  13. Oliver Klee commented on patch set 29 03/17/23, 10:31

    Reply

    Thanks!
  14. Stefan Froemken uploaded patch set 30 CR -1 V +1 03/17/23, 10:41

  15. Stefan Froemken commented on patch set 30 03/17/23, 10:44

    Feature-94499-ImplementAddPageTypeZeroSourceEventListener.rst:59 Reply

    Done

    Feature-94499-ImplementAddPageTypeZeroSourceEventListener.rst:84 Reply

    Done

    Feature-94499-ImplementAddPageTypeZeroSourceEventListener.rst:100 Reply

    Done

    Feature-94499-ImplementAddPageTypeZeroSourceEventListener.rst:105 Reply

    Done

    Feature-94499-ProvideAdditionalPageTypeSourceAuto-createRedirectSourceType.rst:120 Reply

    Done

    Feature-94499-ProvideAdditionalPageTypeSourceAuto-createRedirectSourceType.rst:121 Reply

    Done

    Feature-94499-ProvideAdditionalPageTypeSourceAuto-createRedirectSourceType.rst:121 Reply

    Done

    Feature-94499-ProvideAdditionalPageTypeSourceAuto-createRedirectSourceType.rst:122 Reply

    Done

    Feature-94499-ProvideAdditionalPageTypeSourceAuto-createRedirectSourceType.rst:122 Reply

    Done

    Feature-94499-ProvideAdditionalPageTypeSourceAuto-createRedirectSourceType.rst:122 Reply

    Done

    Feature-94499-ProvideAdditionalPageTypeSourceAuto-createRedirectSourceType.rst:122 Reply

    Done
  16. Stefan Froemken voted on patch set 30 V +1 CR +1 03/17/23, 10:44

  17. core-ci voted on patch set 30 V +1 03/17/23, 10:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39112

  18. Stefan Bürk commented on patch set 30 03/17/23, 11:18

    @Stefan Froemken Thanks a lot. +1 on your changes.

    Feature-94499-ImplementAddPageTypeZeroSourceEventListener.rst:84 Reply

    ack.

    Feature-94499-ImplementAddPageTypeZeroSourceEventListener.rst:100 Reply

    ack.

    Feature-94499-ImplementAddPageTypeZeroSourceEventListener.rst:105 Reply

    ack.

    Feature-94499-ProvideAdditionalPageTypeSourceAuto-createRedirectSourceType.rst:120 Reply

    ack.

    Feature-94499-ProvideAdditionalPageTypeSourceAuto-createRedirectSourceType.rst:121 Reply

    ack.

    Feature-94499-ProvideAdditionalPageTypeSourceAuto-createRedirectSourceType.rst:121 Reply

    ack.

    Feature-94499-ProvideAdditionalPageTypeSourceAuto-createRedirectSourceType.rst:122 Reply

    ack.

    Feature-94499-ProvideAdditionalPageTypeSourceAuto-createRedirectSourceType.rst:122 Reply

    ack.

    Feature-94499-ProvideAdditionalPageTypeSourceAuto-createRedirectSourceType.rst:122 Reply

    ack.

    Feature-94499-ProvideAdditionalPageTypeSourceAuto-createRedirectSourceType.rst:122 Reply

    ack.
  19. Andreas Kienast commented on patch set 30 CR -1 03/27/23, 07:50

    on it
  20. Andreas Kienast uploaded patch set 31 CR +1 V +1 03/27/23, 08:01

  21. Andreas Kienast voted on patch set 31 V +1 CR +1 03/27/23, 08:01

  22. core-ci voted on patch set 31 V +1 03/27/23, 08:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39669

  23. Stefan Froemken commented on patch set 31 V +1 CR +1 03/27/23, 14:53

    After clearing the cache, it works 😄
  24. Stefan Bürk voted on patch set 31 V +2 CR +2 03/27/23, 14:53

  25. Stefan Bürk merged patch set 32 03/27/23, 14:53