Review main Merged

77196[TASK] Streamline the unit tests for ObjectStorage

Oliver Klee CR +2 V +2 Hard +375 −152 updated 12/22/22, 20:39

Commit message

Clean up the existing tests before adding new tests:

- split tests up to test for only one piece of behavior
  where possible
- make the tests more minimal
- improve test naming
- attach proper entities instead of `stdClass`
- add annotations to make use of generics
- use variables for data that should be identical
- reorder the tests to match the order of the methods
  in the tested class

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Torben Hansen +1
  • Verified V +2 Done
    • Benni Mack +2
    • Torben Hansen +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 811

  1. Oliver Klee uploaded patch set 1 12/21/22, 14:18

  2. core-ci voted on patch set 1 V -1 12/21/22, 14:26 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35271

  3. Oliver Klee commented on patch set 1 12/21/22, 14:55

    The test failure seems to be unrelated to my changes.
  4. Oliver Klee rebased onto patch set 2 V -1 12/21/22, 14:56

  5. core-ci voted on patch set 2 V -1 12/21/22, 15:04 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35273

  6. Oliver Klee rebased onto patch set 3 V -1 12/21/22, 15:54

  7. core-ci voted on patch set 3 V +1 12/21/22, 16:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35277

  8. Torben Hansen voted on patch set 3 CR +1 12/22/22, 13:04

  9. Torben Hansen voted on patch set 3 V +1 12/22/22, 17:28

  10. Benni Mack voted on patch set 3 V +2 CR +2 12/22/22, 20:39

  11. Benni Mack merged patch set 4 12/22/22, 20:39