77206[BUGFIX] Enforce validation when no cHash is given
Commit message
Review
-
Code review CR +2 Done
- Oliver Hader +2
- Oli Bartsch +1
-
Verified V +2 Done
- Oliver Hader +2
- Oli Bartsch +1
- core-ci +1 CI
Issues 1
Files 19
- typo3/sysext/core/Configuration/DefaultConfiguration.php+1 −0
- typo3/sysext/core/Configuration/DefaultConfigurationDescription.yaml+3 −0
- typo3/sysext/core/Configuration/FactoryConfiguration.php+3 −0
- typo3/sysext/core/Documentation/Changelog/10.4.x/Important-95297-StrictCHashValidationFeatureFlag.rstnew+41 −0
- typo3/sysext/fluid/Tests/Functional/View/TemplatesPathsTest.php+5 −0
- typo3/sysext/fluid/Tests/Functional/ViewHelpers/Link/TypolinkViewHelperTest.php+8 −0
- typo3/sysext/fluid/Tests/Functional/ViewHelpers/Uri/TypolinkViewHelperTest.php+8 −0
- typo3/sysext/frontend/Classes/Middleware/PageArgumentValidator.php2+25 −1
- typo3/sysext/frontend/Tests/Functional/Rendering/AbsoluteUriPrefixRenderingTest.php+8 −0
- typo3/sysext/frontend/Tests/Functional/Rendering/TitleTagRenderingTest.php+8 −0
- typo3/sysext/frontend/Tests/Functional/Rendering/UriPrefixRenderingTest.php+8 −0
- typo3/sysext/frontend/Tests/Functional/SiteHandling/AbstractTestCase.php+3 −1
- typo3/sysext/frontend/Tests/Functional/SiteHandling/SlugSiteRequestTest.php+1 −0
- typo3/sysext/frontend/Tests/Functional/SiteHandling/SlugSiteWithoutRequiredCHashRequestTest.phpnew+164 −0
- typo3/sysext/redirects/Tests/Functional/Service/RedirectServiceTest.php+10 −0
- typo3/sysext/seo/Tests/Functional/XmlSitemap/XmlSitemapPagesTest.php+8 −0
- typo3/sysext/seo/Tests/Functional/XmlSitemap/XmlSitemapPagesWithHideIfNotTranslatedTest.php+3 −0
- typo3/sysext/seo/Tests/Functional/XmlSitemap/XmlSitemapRecordsTest.php+8 −0
- typo3/sysext/seo/Tests/Functional/XmlSitemap/XmlSitemapXslTest.php+15 −1
Review log 2744
Show 1119 earlier messages
-
Benni Mack uploaded patch set 1 12/23/22, 11:23
-
Benni Mack uploaded patch set 2 12/23/22, 11:24
-
core-ci voted on patch set 1 V -1 12/23/22, 11:39 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35326
-
core-ci voted on patch set 2 V -1 12/23/22, 11:39 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35327
-
Benni Mack uploaded patch set 3
V -101/09/23, 14:00 -
core-ci voted on patch set 3 V -1 01/09/23, 14:12 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35605
-
Benni Mack uploaded patch set 4
V -101/09/23, 14:17 -
core-ci voted on patch set 4 V -1 01/09/23, 14:28 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35606
-
Benni Mack uploaded patch set 5
V -101/09/23, 14:41 -
core-ci voted on patch set 5 V -1 01/09/23, 14:52 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35607
-
Benni Mack uploaded patch set 6
V -101/09/23, 16:00 -
core-ci voted on patch set 6 V -1 01/09/23, 16:11 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35610
-
Benni Mack uploaded patch set 7
V -101/09/23, 18:59 -
core-ci voted on patch set 7 V -1 01/09/23, 19:10 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35613
-
Oliver Hader uploaded patch set 8
V -101/09/23, 20:44 -
Oliver Hader commented on patch set 8 01/09/23, 20:48
-
Oliver Hader commented on patch set 8 01/09/23, 20:49
PageArgumentValidator.php:182ReplyAck -
core-ci voted on patch set 8 V -1 01/09/23, 20:55 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35616
-
Oliver Hader uploaded patch set 9
V -101/09/23, 20:58
-
Oliver Hader uploaded patch set 10 01/09/23, 21:08
-
core-ci voted on patch set 9 V -1 01/09/23, 21:09 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35617
-
core-ci voted on patch set 10 V -1 01/09/23, 21:17 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35618
-
Oliver Hader uploaded patch set 11
V -101/09/23, 21:25 -
core-ci voted on patch set 11 V +1 01/09/23, 21:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35619
-
Benni Mack uploaded patch set 12
V +101/09/23, 22:35 -
core-ci voted on patch set 12 V +1 01/09/23, 22:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35620
-
Markus Klein commented on patch set 12 01/10/23, 08:11
That's not making much sense. I *think* you meant: > When no cHash is given but GET parameters are handed in which _would_ require a cHash parameter -
Benni Mack uploaded patch set 13
V +101/23/23, 22:21 -
Benni Mack updated the commit message in patch set 14 01/23/23, 22:22
-
core-ci voted on patch set 13 V +1 01/23/23, 22:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36498
-
core-ci voted on patch set 14 V +1 01/23/23, 22:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36499
-
Benni Mack commented on patch set 14 01/23/23, 22:34
Reply
Done -
Benni Mack uploaded patch set 15
V +101/27/23, 08:59 -
core-ci voted on patch set 15 V +1 01/27/23, 09:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36677
-
Oli Bartsch uploaded patch set 16
V +101/27/23, 10:47 -
Oli Bartsch voted on patch set 16 V +1 CR +1 01/27/23, 10:47
-
core-ci voted on patch set 16 V +1 01/27/23, 10:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36686
-
Oliver Hader voted on patch set 16 V +1 CR +1 02/06/23, 14:52
-
Oliver Hader updated the commit message in patch set 17
CR +1V +102/06/23, 15:48 -
Oliver Hader voted on patch set 17 V +1 CR +1 02/06/23, 15:49
-
Oli Bartsch voted on patch set 17 V +1 CR +1 02/06/23, 16:13
-
core-ci voted on patch set 17 V +1 02/06/23, 16:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37180
-
Oliver Hader voted on patch set 17 V +2 CR +2 02/06/23, 16:29
-
Oliver Hader merged patch set 18 02/06/23, 16:29
PageArgumentValidator.php:182