77207[TASK] Enforce types in HtmlParser / RteHtmlParser
Commit message
Review
-
Code review CR +2 Done
- Oli Bartsch +2
- Oliver Klee +1
-
Verified V +2 Done
- Oli Bartsch +2
- Oliver Klee +1
- core-ci +1 CI
Issues 1
Files 2
Review log 1013
-
Benni Mack uploaded patch set 1 12/23/22, 13:33
-
core-ci voted on patch set 1 V +1 12/23/22, 13:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35328
-
Benni Mack updated the commit message in patch set 2
V +112/23/22, 21:26 -
core-ci voted on patch set 2 V +1 12/23/22, 21:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35331
-
Oliver Klee commented on patch set 2 12/23/22, 22:51
RteHtmlParser.php:253We can remove this line now.RteHtmlParser.php:478Why did the default value get removed? (That is a change in behavior.) -
Benni Mack commented on patch set 2 01/03/23, 22:45
RteHtmlParser.php:478ReplyThe method is protected and always called with an argument, thus, no need to keep a default value for the argument. -
Oli Bartsch uploaded patch set 3
V +101/04/23, 08:28 -
Oli Bartsch commented on patch set 2 V +1 CR +1 01/04/23, 08:33
HtmlParser.php:3ReplyIn the current state, this would lead to a couple of TypeError exceptions. The purpose of this patch is to "just" add types to protected properties and methods. I therefore think we should do a separate patch to introduce strict types for this class, since this requires a lot more work. Do you agree?RteHtmlParser.php:253ReplyDoneRteHtmlParser.php:478ReplyDone -
core-ci voted on patch set 3 V +1 01/04/23, 08:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35455
-
Oliver Klee commented on patch set 3 V +1 CR +1 01/04/23, 13:44
HtmlParser.php:3ReplyAck -
Oli Bartsch voted on patch set 3 CR +2 01/04/23, 16:02
-
Oli Bartsch voted on patch set 3 V +2 01/04/23, 16:02
-
Oli Bartsch merged patch set 4 01/04/23, 16:02
HtmlParser.php:3