Review main Merged

77208[BUGFIX] Handle absolute web paths in FormEngineUtility::getIconHtml

Nikita Hovratov CR +2 V +2 Easy +7 −2 updated 01/17/23, 18:06

Commit message

Since the introduction of always absolute (web) paths inside the TYPO3
backend, the TCA ctrl option `selicon_field` didn't work anymore since
relative web paths like `fileadmin/file.png` changed to
`/fileadmin/file.png`, which were not handled and resulted in a missing
icon.

This patch extends the condition for checking for absolute paths and
prevents the GU:getFileAbsFileName method from turning web paths into
empty strings.

Review

  • Code review CR +2 Done
    • Nikita Hovratov +2
    • Jasmina Ließmann +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Nikita Hovratov +2
    • Jasmina Ließmann +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 3

Files 1

Review log 1316

  1. Nikita Hovratov uploaded patch set 1 12/23/22, 13:57

  2. core-ci voted on patch set 1 V -1 12/23/22, 14:04 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35329

  3. Benni Mack commented on patch set 1 12/23/22, 14:41

    FormEngineUtility.php:18

    maybe we can get rid of it.
  4. Nikita Hovratov uploaded patch set 2 V -1 12/23/22, 17:30

  5. Nikita Hovratov commented on patch set 1 12/23/22, 17:30

    FormEngineUtility.php:18 Reply

    Done
  6. core-ci voted on patch set 2 V +1 12/23/22, 17:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35330

  7. Oliver Klee voted on patch set 2 CR +1 12/24/22, 09:57

  8. Anja Leichsenring voted on patch set 2 V +1 CR +1 12/25/22, 12:17

  9. Helmut Hummel commented on patch set 2 12/27/22, 10:39

    FormEngineUtility.php:134

    Hey, Nikkitia. Thanks for this change. Can this be changed, in a way, that the file object isn't converted to a string, but passed as object, so that we can call getPublicUrl() here then?
  10. Nikita Hovratov commented on patch set 2 12/27/22, 10:43

    FormEngineUtility.php:134 Reply

    Hey Helmut, sounds reasonable. If you want, you can adapt this patch. You have far better knowledge in this area.
  11. Nikita Hovratov rebased onto patch set 3 CR +1 V +1 01/16/23, 14:00

  12. core-ci voted on patch set 3 V +1 01/16/23, 14:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35853

  13. Christian Kuhn commented on patch set 3 V +1 CR +1 01/17/23, 17:43

    FormEngineUtility.php:134 Reply

    I'm afraid this won't work for now due to the TCA construct / sources.
  14. Jasmina Ließmann voted on patch set 3 V +1 CR +1 01/17/23, 17:46

  15. Nikita Hovratov voted on patch set 3 V +2 CR +2 01/17/23, 18:06

  16. Nikita Hovratov merged patch set 4 01/17/23, 18:06