77208[BUGFIX] Handle absolute web paths in FormEngineUtility::getIconHtml
Commit message
Review
-
Code review CR +2 Done
- Nikita Hovratov +2
- Jasmina Ließmann +1
- Christian Kuhn +1
-
Verified V +2 Done
- Nikita Hovratov +2
- Jasmina Ließmann +1
- Christian Kuhn +1
- core-ci +1 CI
Issues 3
Files 1
Review log 1316
-
Nikita Hovratov uploaded patch set 1 12/23/22, 13:57
-
core-ci voted on patch set 1 V -1 12/23/22, 14:04 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35329
-
Benni Mack commented on patch set 1 12/23/22, 14:41
-
Nikita Hovratov uploaded patch set 2
V -112/23/22, 17:30 -
Nikita Hovratov commented on patch set 1 12/23/22, 17:30
FormEngineUtility.php:18ReplyDone -
core-ci voted on patch set 2 V +1 12/23/22, 17:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35330
-
Oliver Klee voted on patch set 2 CR +1 12/24/22, 09:57
-
Anja Leichsenring voted on patch set 2 V +1 CR +1 12/25/22, 12:17
-
Helmut Hummel commented on patch set 2 12/27/22, 10:39
FormEngineUtility.php:134Hey, Nikkitia. Thanks for this change. Can this be changed, in a way, that the file object isn't converted to a string, but passed as object, so that we can call getPublicUrl() here then? -
Nikita Hovratov commented on patch set 2 12/27/22, 10:43
FormEngineUtility.php:134ReplyHey Helmut, sounds reasonable. If you want, you can adapt this patch. You have far better knowledge in this area. -
Nikita Hovratov rebased onto patch set 3
CR +1V +101/16/23, 14:00 -
core-ci voted on patch set 3 V +1 01/16/23, 14:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35853
-
Christian Kuhn commented on patch set 3 V +1 CR +1 01/17/23, 17:43
FormEngineUtility.php:134ReplyI'm afraid this won't work for now due to the TCA construct / sources. -
Jasmina Ließmann voted on patch set 3 V +1 CR +1 01/17/23, 17:46
-
Nikita Hovratov voted on patch set 3 V +2 CR +2 01/17/23, 18:06
-
Nikita Hovratov merged patch set 4 01/17/23, 18:06
FormEngineUtility.php:18