Review main Merged

7721[BUGFIX] Checkbox values not shown in emails

Sebastian Müller CR +2 V +2 Easy +4 −5 updated 07/18/15, 11:36

Commit message

Emails sent by FORM sysext do not show the values of checkboxes, in case
of they were checked.

Review

  • Code review CR +2
    • Benni Mack +2
    • Markus Sommer +1
  • Verified V +2
    • Benni Mack +2
    • Harry Glatz +1
    • Markus Sommer +1

Issues 1

Files 1

Review log 21

  1. Stefan Neufeind commented on patch set 2 05/27/13, 17:19

    (1 inline comment)
    4.8

    Reply

    6.0 meanwhile :-)
  2. Stefan Neufeind commented on patch set 2 1 comment 05/27/13, 17:19

    Looks good to me, but someone else must approve haven't tested it yet, but reading the desc/source I understand that if there is a value (value of the checkbox9 you take that value and the element is not treated as empty anymore? Then I think that should be okay
  3. Stefan Neufeind commented on patch set 3 05/27/13, 17:19

    hand-rebased, updated releases-line
  4. Stefan Neufeind uploaded patch set 3 05/27/13, 17:19

  5. Steffen Gebert uploaded patch set 2 05/27/13, 17:19

  6. Steffen Gebert commented on patch set 2 05/27/13, 17:19

    Ouch.. looks like Jenkins crashed Caused by: java.lang.OutOfMemoryError Will remove voting and notify admins..
  7. Mr. Jenkins commented on patch set 1 05/27/13, 17:19

  8. Mr. Jenkins commented on patch set 2 05/27/13, 17:19

    Fails; I would prefer that you didn't submit this Build Failed https://ci.typo3.org/job/typo3-v4-core-gerrit/2937/ : FAILURE
  9. Mr. Jenkins commented on patch set 2 05/27/13, 17:19

  10. Mr. Jenkins commented on patch set 3 05/27/13, 17:19

  11. Wouter Wolters uploaded patch set 4 05/28/13, 18:42

  12. Mr. Jenkins commented on patch set 4 05/28/13, 18:42

  13. Mathias Schreiber wrote 12/14/14, 15:55

    Topic changed from 33092 to EXT: Form
  14. Alexander Opitz updated the commit message in patch set 5 01/23/15, 12:35

  15. Alexander Opitz commented on patch set 5 01/23/15, 12:36

    What is the state of this patch?
  16. Benni Mack voted on patch set 5 CR +1 07/17/15, 13:38

  17. Harry Glatz voted on patch set 5 V +1 07/17/15, 19:29

  18. Markus Sommer voted on patch set 5 CR +1 V +1 07/18/15, 10:28

  19. Benni Mack voted on patch set 5 CR +2 V +2 07/18/15, 11:35

  20. Benni Mack merged patch set 5 07/18/15, 11:35

  21. Benni Mack commented on patch set 6 07/18/15, 11:36

    Cherry Picked This patchset was cherry picked to branch TYPO3_6-2 as commit 5e7061f46b00843c6b435b25e40b02928ad657b6