Review main Merged

77234[TASK] Drop dev dependency phpspec/prophecy

Nikita Hovratov CR +2 V +2 Normal +5 −203 updated 12/29/22, 08:36

Commit message

The mocking framework prophecy is considered dead and is already dropped
in phpunit. All occurrences in the codebase have been replaced with
corresponding phpunit mocks or have been converted to functional tests.

This patch removes the composer dependency and allows to remove the
workarounds for ignoring the php platform checks in the test setup.

Run command:
> composer remove --dev \
phpspec/prophecy \
phpspec/prophecy-phpunit \
jangregor/phpstan-prophecy

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Oliver Klee +1
    • Torben Hansen +1
    • Benni Mack +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Oliver Klee +1
    • Torben Hansen +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 5

Review log 710

  1. Nikita Hovratov uploaded patch set 1 12/28/22, 15:23

  2. core-ci voted on patch set 1 V +1 12/28/22, 15:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35376

  3. core-ci voted on patch set 1 V -1 12/28/22, 16:03 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35378

  4. core-ci voted on patch set 1 V +1 12/28/22, 16:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35378

  5. Nikita Hovratov commented on patch set 1 12/28/22, 16:12

    ^ nightly run is green
  6. Torben Hansen voted on patch set 1 V +1 CR +1 12/28/22, 17:16

  7. Oliver Klee voted on patch set 1 V +1 CR +1 12/28/22, 17:21

  8. Benni Mack voted on patch set 1 V +1 CR +1 12/28/22, 22:55

  9. Georg Ringer voted on patch set 1 V +2 CR +2 12/29/22, 08:36

  10. Georg Ringer merged patch set 2 12/29/22, 08:36