Review main Abandoned

77237[TASK] Activate t3editor for all TSconfig fields

Torben Hansen CR 0 V 0 Easy +18 −0 updated 01/06/23, 20:13

Commit message

The t3editor is active for several TSconfig fields in
`be_groups`, `be_users` and `pages`. For the TSconfig
field in `fe_groups` and `fe_users` the editor is not
active.

This patch activates the t3editor for the TSconfig
field in `fe_groups` and `fe_users`.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 2

Review log 67

  1. Torben Hansen uploaded patch set 1 12/29/22, 10:16

  2. core-ci voted on patch set 1 V +1 12/29/22, 10:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35391

  3. Guido Schmechel voted on patch set 1 V +1 CR +1 12/29/22, 15:59

  4. Georg Ringer voted on patch set 1 V +1 CR +1 12/30/22, 08:03

  5. Christian Kuhn commented on patch set 1 CR -1 01/05/23, 15:46

    I don't think we should do this anymore: * The fields are deprecated in v12, it does not make much sense to add additional features to it. We could argue about v11, but even for v11 I don't think it makes too much sense. * This creates a dependency from ext:t3editor to ext:frontend which would be better to avoid (or at least checked with an isLoaded(), maybe? Are Override files loaded for TCA tables that don't exist yet?
  6. Stefan Bürk commented on patch set 1 CR -1 01/06/23, 20:13

    Reply

    Fully ack with what lolli wrote. This does not make much sense to add this in previous version.
  7. Christian Kuhn abandoned the change 01/06/23, 20:13