Review main Merged

77239[FEATURE] Display available commands in scheduler

Georg Ringer CR +2 V +2 Normal +142 −38 updated 03/24/23, 11:39

Commit message

The scheduler submodule "Available scheduler commands"
lists all registered scheduler commands.

This list is now grouped by the extension name to
improve readability.

Additionally, cli commands that can be executed as
scheduler commands are now listed as well.

Minor drive-by changes are applied along the way.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Benni Mack +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 8

Review log 2736

Show 811 earlier messages
  1. Georg Ringer uploaded patch set 1 12/30/22, 14:41

  2. core-ci voted on patch set 1 V +1 12/30/22, 14:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35402

  3. Georg Ringer commented on patch set 1 12/30/22, 15:48

    This change is ready for review.
  4. Oliver Klee updated the commit message in patch set 2 V +1 12/30/22, 17:04

  5. core-ci voted on patch set 2 V +1 12/30/22, 17:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35404

  6. Torben Hansen commented on patch set 2 01/01/23, 12:02

    Feature-99436-ListCommandsInSchedulerModule.rst:14

    Should be "Commands"
  7. Chris Müller uploaded patch set 3 V +1 01/05/23, 18:53

  8. Chris Müller commented on patch set 3 01/05/23, 18:53

    Feature-99436-ListCommandsInSchedulerModule.rst:14 Reply

    Done
  9. core-ci voted on patch set 3 V +1 01/05/23, 19:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35507

  10. Guido Schmechel commented on patch set 3 01/05/23, 21:39

    Notes regarding the output: - By changing from table-fit to table-responsive, the border is lost. We could use .table-bordered - The list of commands can become quite long. I would also include an thead level here with the "vendor", as with the tasks. - The plus buttons are not aligned flush. Unfortunately, I dont know what the correct way for width is
  11. Georg Ringer uploaded patch set 4 V +1 01/11/23, 11:55

  1. Georg Ringer commented on patch set 3 01/11/23, 11:56

    Reply

    - I don't get the vendor name there. - I moved the plus button to the left, so those are now all aligned
  2. core-ci voted on patch set 4 V +1 01/11/23, 12:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35680

  3. Christian Kuhn commented on patch set 4 CR -1 01/11/23, 12:51

    ExecuteSchedulableCommandAdditionalFieldProvider.php:246

    this is rather hacky since it misuses the additional field provider of this task as a model for existing scheduable commands. this should be solved differently.

    ExecuteSchedulableCommandAdditionalFieldProvider.php:422

    that's another sign this class is misused.
  4. Georg Ringer commented on patch set 4 01/11/23, 16:33

    ExecuteSchedulableCommandAdditionalFieldProvider.php:246 Reply

    i know but as as long as the commands are just an additional field of the task to execute those there is no other way. If we are able to get rid of the existing tasks and deprecate those we can change all that to something nicer. currently I don't see any other way and as commands are used far more often the feature is imo more important than the bit hacky solution
  5. Christian Kuhn commented on patch set 4 01/11/23, 16:47

    ExecuteSchedulableCommandAdditionalFieldProvider.php:246 Reply

    I get your point but disagree. I think it should be possible to extract the list compilation of commands to some service class and use this instead, or is there some hard blocker i missed?
  6. Benni Mack uploaded patch set 5 CR -1 V +1 03/22/23, 22:23

  7. core-ci voted on patch set 5 V +1 03/22/23, 22:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39423

  8. Georg Ringer voted on patch set 5 V +1 CR +1 03/23/23, 07:57

  9. Christian Kuhn commented on patch set 5 CR -1 03/23/23, 08:46

    this is still a hack. let's not rush in late features that adds such technical debt.
  10. Christian Kuhn uploaded patch set 6 CR +1 V +1 03/24/23, 08:59

  11. Christian Kuhn commented on patch set 6 CR -1 03/24/23, 09:01

    patch set 6 avoids the access to GLOBALS['TYPO3_REQUEST'].
  12. Christian Kuhn commented on patch set 6 03/24/23, 09:01

    ExecuteSchedulableCommandAdditionalFieldProvider.php:422 Reply

    Done
  13. core-ci voted on patch set 6 V +1 03/24/23, 09:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39530

  14. Christian Kuhn uploaded patch set 7 CR -1 V +1 03/24/23, 09:33

  15. Christian Kuhn commented on patch set 6 CR -1 03/24/23, 09:34

    ExecuteSchedulableCommandAdditionalFieldProvider.php:246 Reply

    Fixed by injecting the CommandRegistry into the controller and using that to create the list: Less code, no hack, simple solution.
  16. Christian Kuhn uploaded patch set 8 03/24/23, 09:55

  17. core-ci voted on patch set 7 V +1 03/24/23, 10:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39531

  18. Christian Kuhn voted on patch set 8 V +1 CR +1 03/24/23, 10:38

  19. Christian Kuhn commented on patch set 8 V 0 CR 0 03/24/23, 10:38

    unit tests fail ...
  20. core-ci voted on patch set 8 V -1 03/24/23, 10:42 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39532

  21. Christian Kuhn uploaded patch set 9 V -1 03/24/23, 10:44

  22. core-ci voted on patch set 9 V +1 03/24/23, 10:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39537

  23. Christian Kuhn voted on patch set 9 V +1 CR +1 03/24/23, 10:55

  24. Benni Mack voted on patch set 9 V +2 CR +2 03/24/23, 11:39

  25. Benni Mack merged patch set 10 03/24/23, 11:39