77239[FEATURE] Display available commands in scheduler
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Christian Kuhn +1
-
Verified V +2 Done
- Benni Mack +2
- Christian Kuhn +1
- core-ci +1 CI
Issues 1
Files 8
- typo3/sysext/core/Documentation/Changelog/12.3/Feature-99436-ListCommandsInSchedulerModule.rstnew+28 −0
- typo3/sysext/core/Tests/Acceptance/Application/Scheduler/TasksCest.php+2 −2
- typo3/sysext/recycler/Tests/Unit/Task/CleanerFieldProviderTest.php+1 −1
- typo3/sysext/scheduler/Classes/Controller/AvailableSchedulerTasksController.php+41 −12
- typo3/sysext/scheduler/Classes/Controller/SchedulerSetupCheckController.php+3 −4
- typo3/sysext/scheduler/Classes/Task/ExecuteSchedulableCommandAdditionalFieldProvider.php6+11 −7
- typo3/sysext/scheduler/Resources/Private/Language/locallang.xlf+5 −2
- typo3/sysext/scheduler/Resources/Private/Templates/InfoScreen.html+51 −10
Review log 2736
Show 811 earlier messages
-
Georg Ringer uploaded patch set 1 12/30/22, 14:41
-
core-ci voted on patch set 1 V +1 12/30/22, 14:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35402
-
Georg Ringer commented on patch set 1 12/30/22, 15:48
This change is ready for review. -
Oliver Klee updated the commit message in patch set 2
V +112/30/22, 17:04 -
core-ci voted on patch set 2 V +1 12/30/22, 17:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35404
-
Torben Hansen commented on patch set 2 01/01/23, 12:02
Feature-99436-ListCommandsInSchedulerModule.rst:14Should be "Commands" -
Chris Müller uploaded patch set 3
V +101/05/23, 18:53 -
Chris Müller commented on patch set 3 01/05/23, 18:53
Feature-99436-ListCommandsInSchedulerModule.rst:14ReplyDone -
core-ci voted on patch set 3 V +1 01/05/23, 19:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35507
-
Guido Schmechel commented on patch set 3 01/05/23, 21:39
Notes regarding the output: - By changing from table-fit to table-responsive, the border is lost. We could use .table-bordered - The list of commands can become quite long. I would also include an thead level here with the "vendor", as with the tasks. - The plus buttons are not aligned flush. Unfortunately, I dont know what the correct way for width is -
Georg Ringer uploaded patch set 4
V +101/11/23, 11:55
-
Georg Ringer commented on patch set 3 01/11/23, 11:56
Reply
- I don't get the vendor name there. - I moved the plus button to the left, so those are now all aligned -
core-ci voted on patch set 4 V +1 01/11/23, 12:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35680
-
Christian Kuhn commented on patch set 4 CR -1 01/11/23, 12:51
ExecuteSchedulableCommandAdditionalFieldProvider.php:246this is rather hacky since it misuses the additional field provider of this task as a model for existing scheduable commands. this should be solved differently.ExecuteSchedulableCommandAdditionalFieldProvider.php:422that's another sign this class is misused. -
Georg Ringer commented on patch set 4 01/11/23, 16:33
ExecuteSchedulableCommandAdditionalFieldProvider.php:246Replyi know but as as long as the commands are just an additional field of the task to execute those there is no other way. If we are able to get rid of the existing tasks and deprecate those we can change all that to something nicer. currently I don't see any other way and as commands are used far more often the feature is imo more important than the bit hacky solution -
Christian Kuhn commented on patch set 4 01/11/23, 16:47
ExecuteSchedulableCommandAdditionalFieldProvider.php:246ReplyI get your point but disagree. I think it should be possible to extract the list compilation of commands to some service class and use this instead, or is there some hard blocker i missed? -
Benni Mack uploaded patch set 5
CR -1V +103/22/23, 22:23 -
core-ci voted on patch set 5 V +1 03/22/23, 22:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39423
-
Georg Ringer voted on patch set 5 V +1 CR +1 03/23/23, 07:57
-
Christian Kuhn commented on patch set 5 CR -1 03/23/23, 08:46
this is still a hack. let's not rush in late features that adds such technical debt. -
Christian Kuhn uploaded patch set 6
CR +1V +103/24/23, 08:59 -
Christian Kuhn commented on patch set 6 CR -1 03/24/23, 09:01
patch set 6 avoids the access to GLOBALS['TYPO3_REQUEST']. -
Christian Kuhn commented on patch set 6 03/24/23, 09:01
ExecuteSchedulableCommandAdditionalFieldProvider.php:422ReplyDone -
core-ci voted on patch set 6 V +1 03/24/23, 09:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39530
-
Christian Kuhn uploaded patch set 7
CR -1V +103/24/23, 09:33 -
Christian Kuhn commented on patch set 6 CR -1 03/24/23, 09:34
ExecuteSchedulableCommandAdditionalFieldProvider.php:246ReplyFixed by injecting the CommandRegistry into the controller and using that to create the list: Less code, no hack, simple solution. -
Christian Kuhn uploaded patch set 8 03/24/23, 09:55
-
core-ci voted on patch set 7 V +1 03/24/23, 10:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39531
-
Christian Kuhn voted on patch set 8 V +1 CR +1 03/24/23, 10:38
-
Christian Kuhn commented on patch set 8 V 0 CR 0 03/24/23, 10:38
unit tests fail ... -
core-ci voted on patch set 8 V -1 03/24/23, 10:42 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39532
-
Christian Kuhn uploaded patch set 9
V -103/24/23, 10:44 -
core-ci voted on patch set 9 V +1 03/24/23, 10:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39537
-
Christian Kuhn voted on patch set 9 V +1 CR +1 03/24/23, 10:55
-
Benni Mack voted on patch set 9 V +2 CR +2 03/24/23, 11:39
-
Benni Mack merged patch set 10 03/24/23, 11:39