Review main Merged

77255[BUGFIX] Restore visibility for soft hyphens and non-breaking spaces

Benjamin Kott CR +2 V +2 Normal +214 −31 updated 01/09/23, 13:33

Commit message

Non-breaking spaces and soft hyphens are now visible in
the editor to help the editor to identify them visually.

Keyboard shortcuts are now working for non-breaking spaces
and soft hyphens and use more common defaults:
- ctrl+shift+space for non-breaking space
- ctrl+shift+dash for soft hyphen

Please note that MacOS use different shortcuts:
- alt+shift+space for non-breaking space
- alt+shift+dash for soft hyphen

The SoftHyphen plugin for CKEditor is now deprecated and
replaced with a new Whitespace Plugin that handles
non-breaking spaces and soft hyphens. Loading the
SoftHyphen will trigger a console warning.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Frank Nägler +1
  • Verified V +2 Done
    • Benni Mack +2
    • Frank Nägler +1
    • core-ci +1 CI

Issues 1

Files 10

Review log 1317

  1. Benjamin Kott uploaded patch set 1 01/04/23, 14:23

  2. core-ci voted on patch set 1 V +1 01/04/23, 14:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35459

  3. Benjamin Kott uploaded patch set 2 V +1 01/04/23, 14:36

  4. core-ci voted on patch set 2 V +1 01/04/23, 14:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35460

  5. Helmut Hummel commented on patch set 2 01/05/23, 11:55

    From reading, this is a great change! Only have a question code wise.

    Default.yaml:64

    This change does not seem to belong here, or does it?
  6. Helmut Hummel commented on patch set 2 01/05/23, 11:57

    Full.yaml:79

    This removal also does not belong in this change?
  7. Benjamin Kott commented on patch set 2 01/05/23, 12:49

    Default.yaml:64 Reply

    yes it seems i have mixed up changes while breaking up the patch

    Full.yaml:79 Reply

    you are right, will fix it - belongs to a different patch
  8. Benjamin Kott uploaded patch set 3 V +1 01/05/23, 12:53

  9. Benjamin Kott commented on patch set 3 01/05/23, 12:54

    Default.yaml:64 Reply

    Done

    Full.yaml:79 Reply

    Done
  10. core-ci voted on patch set 3 V +1 01/05/23, 13:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35486

  11. Helmut Hummel commented on patch set 3 CR +1 01/05/23, 13:11

    Haven't tested for now, but changes look good now from reading!
  12. Markus Klein voted on patch set 3 CR +1 01/06/23, 10:58

  13. Benjamin Kott uploaded patch set 4 CR +1 V +1 01/09/23, 12:15

  14. Frank Nägler voted on patch set 4 V +1 CR +1 01/09/23, 12:17

  15. core-ci voted on patch set 4 V +1 01/09/23, 12:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35602

  16. Benni Mack voted on patch set 4 V +2 CR +2 01/09/23, 13:33

  17. Benni Mack merged patch set 5 01/09/23, 13:33