77255[BUGFIX] Restore visibility for soft hyphens and non-breaking spaces
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Frank Nägler +1
-
Verified V +2 Done
- Benni Mack +2
- Frank Nägler +1
- core-ci +1 CI
Issues 1
Files 10
- Build/Sources/TypeScript/rte_ckeditor/plugin/soft-hyphen.ts+4 −23
- Build/Sources/TypeScript/rte_ckeditor/plugin/whitespace.tsnew+102 −0
- typo3/sysext/core/Classes/Configuration/CKEditor5Migrator.php+2 −1
- typo3/sysext/core/Documentation/Changelog/12.2/Deprecation-99454-RestoreVisibilityForSoftHyphensAndNonBreakingSpaces.rstnew+64 −0
- typo3/sysext/rte_ckeditor/Configuration/RTE/Editor/Plugins.yaml+2 −2
- typo3/sysext/rte_ckeditor/Configuration/RTE/Default.yaml3+1 −1
- typo3/sysext/rte_ckeditor/Configuration/RTE/Full.yaml3+3 −3
- typo3/sysext/rte_ckeditor/Resources/Public/Css/editor.css+22 −0
- typo3/sysext/rte_ckeditor/Resources/Public/JavaScript/plugin/soft-hyphen.js+1 −1
- typo3/sysext/rte_ckeditor/Resources/Public/JavaScript/plugin/whitespace.jsnew+13 −0
Review log 1317
-
Benjamin Kott uploaded patch set 1 01/04/23, 14:23
-
core-ci voted on patch set 1 V +1 01/04/23, 14:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35459
-
Benjamin Kott uploaded patch set 2
V +101/04/23, 14:36 -
core-ci voted on patch set 2 V +1 01/04/23, 14:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35460
-
Helmut Hummel commented on patch set 2 01/05/23, 11:55
From reading, this is a great change! Only have a question code wise.Default.yaml:64This change does not seem to belong here, or does it? -
Helmut Hummel commented on patch set 2 01/05/23, 11:57
Full.yaml:79This removal also does not belong in this change? -
Benjamin Kott commented on patch set 2 01/05/23, 12:49
Default.yaml:64Replyyes it seems i have mixed up changes while breaking up the patchFull.yaml:79Replyyou are right, will fix it - belongs to a different patch -
Benjamin Kott uploaded patch set 3
V +101/05/23, 12:53 -
Benjamin Kott commented on patch set 3 01/05/23, 12:54
Default.yaml:64ReplyDoneFull.yaml:79ReplyDone -
core-ci voted on patch set 3 V +1 01/05/23, 13:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35486
-
Helmut Hummel commented on patch set 3 CR +1 01/05/23, 13:11
Haven't tested for now, but changes look good now from reading! -
Markus Klein voted on patch set 3 CR +1 01/06/23, 10:58
-
Benjamin Kott uploaded patch set 4
CR +1V +101/09/23, 12:15 -
Frank Nägler voted on patch set 4 V +1 CR +1 01/09/23, 12:17
-
core-ci voted on patch set 4 V +1 01/09/23, 12:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35602
-
Benni Mack voted on patch set 4 V +2 CR +2 01/09/23, 13:33
-
Benni Mack merged patch set 5 01/09/23, 13:33