Review main Merged

77257[BUGFIX] Prevent exception in TranslateViewHelper for modules without title

Oli Bartsch CR +2 V +2 Easy +10 −2 updated 01/05/23, 16:19

Commit message

In case modules do not provide a "title" or
"shortDescription" the module is now displayed
in the module menu again without a title and does
therefore no longer trigger a ViewHelper exception.

This is the same procedure as for the listing in the
"About TYPO3" module.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Stefan Bürk +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Stefan Bürk +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 810

  1. Oli Bartsch uploaded patch set 1 01/04/23, 15:16

  2. core-ci voted on patch set 1 V +1 01/04/23, 15:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35466

  3. Christian Kuhn voted on patch set 1 V +1 CR +1 01/05/23, 13:17

  4. Stefan Bürk voted on patch set 1 V +1 CR +1 01/05/23, 15:02

  5. Oli Bartsch updated the commit message in patch set 2 CR +1 V +1 01/05/23, 15:53

  6. Stefan Bürk voted on patch set 2 V +1 CR +1 01/05/23, 15:54

  7. Christian Kuhn voted on patch set 2 V +1 CR +1 01/05/23, 15:57

  8. core-ci voted on patch set 2 V +1 01/05/23, 16:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35502

  9. Oli Bartsch voted on patch set 2 V +2 CR +2 01/05/23, 16:19

  10. Oli Bartsch merged patch set 3 01/05/23, 16:19