Review main Merged

77260[BUGFIX] Fix array access warning in SystemStatusUpdateTask

Helmut Hummel CR +2 V +2 Easy +1 −1 updated 01/06/23, 15:20

Commit message

When this task is executed on CLI (scheduler), the global request variable
is not available, thus a null check must be added before checking the instance
of the value.

Review

  • Code review CR +2 Done
    • Helmut Hummel +2
    • Oli Bartsch +1
    • Oliver Klee +1
    • Torben Hansen +1
    • Stefan Bürk +1
    • Christian Kuhn +1
    • Benjamin Kott +1
  • Verified V +2 Done
    • Helmut Hummel +2
    • Oli Bartsch +1
    • Torben Hansen +1
    • Stefan Bürk +1
    • Christian Kuhn +1
    • Benjamin Kott +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1011

  1. Helmut Hummel uploaded patch set 1 01/05/23, 11:51

  2. core-ci voted on patch set 1 V +1 01/05/23, 11:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35482

  3. Benjamin Kott voted on patch set 1 V +1 CR +1 01/05/23, 12:47

  4. Torben Hansen voted on patch set 1 V +1 CR +1 01/05/23, 12:49

  5. Christian Kuhn voted on patch set 1 V +1 CR +1 01/05/23, 13:02

  6. Christian Kuhn commented on patch set 1 01/05/23, 13:05

    i'd tend to leave out v10, but it's your choice when you merge it.
  7. Oli Bartsch voted on patch set 1 V +1 CR +1 01/05/23, 13:20

  8. Stefan Bürk voted on patch set 1 V +1 CR +1 01/05/23, 13:21

  9. Oliver Klee voted on patch set 1 CR +1 01/05/23, 20:24

  10. Helmut Hummel commented on patch set 1 V +2 CR +2 01/06/23, 15:20

    Thanks for the quick votes!
  11. Helmut Hummel merged patch set 2 01/06/23, 15:20