Review main Merged

77262[BUGFIX] Accessing unavailable site config triggers notice instead of warning

Helmut Hummel CR +2 V +2 Easy +1 −1 updated 01/06/23, 20:10

Commit message

Accessing a not available configuration via TypoScript can be
intentional (e.g. by using it in an if check).
Therefore the log entry severity should rather be downgraded to a notice.

Review

  • Code review CR +2 Done
    • Helmut Hummel +2
    • Oli Bartsch +1
    • Stefan Bürk +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Helmut Hummel +2
    • Oli Bartsch +1
    • Stefan Bürk +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 78

  1. Helmut Hummel uploaded patch set 1 01/05/23, 12:36

  2. core-ci voted on patch set 1 V +1 01/05/23, 12:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35484

  3. Christian Kuhn commented on patch set 1 V +1 CR +1 01/05/23, 13:05

    i'd tend to leave out v10, but it's your choice when you merge it.
  4. Stefan Bürk commented on patch set 1 V +1 CR +1 01/05/23, 13:20

    Reply

    ^same.
  5. Oli Bartsch voted on patch set 1 V +1 CR +1 01/05/23, 13:20

  6. Helmut Hummel commented on patch set 1 V +2 CR +2 01/06/23, 15:21

    Thanks for the reviews!
  7. Helmut Hummel merged patch set 2 01/06/23, 15:21

  8. Christian Kuhn commented on patch set 2 01/06/23, 20:10

    10.4 backport skipped.