Review main Merged

77263[BUGFIX] Avoid undefined array key in ObjectStorage::offsetGet()

Daniel Siepmann CR +2 V +2 Easy +25 −2 updated 01/06/23, 08:18

Commit message

Requesting an none existing entry resulted in an PHP Warning in newer
PHP 8.x versions.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
    • Nikita Hovratov +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
    • Nikita Hovratov +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 79

  1. Daniel Siepmann uploaded patch set 1 01/05/23, 13:44

  2. core-ci voted on patch set 1 V -1 01/05/23, 13:56 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35490

  3. Daniel Siepmann uploaded patch set 2 V -1 01/05/23, 14:53

  4. core-ci voted on patch set 2 V +1 01/05/23, 15:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35495

  5. Christian Kuhn voted on patch set 2 V +1 CR +1 01/05/23, 16:07

  6. Nikita Hovratov voted on patch set 2 V +1 CR +1 01/05/23, 16:39

  7. Oliver Klee voted on patch set 2 V +1 CR +1 01/05/23, 19:36

  8. Christian Kuhn voted on patch set 2 V +2 CR +2 01/06/23, 08:18

  9. Christian Kuhn merged patch set 3 01/06/23, 08:18