Review main Merged

77264[BUGFIX] Prevent undefined array offset warnings in ElementInformationController

Oli Bartsch CR +2 V +2 Easy +4 −4 updated 01/05/23, 15:54

Commit message

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Stefan Bürk +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Stefan Bürk +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 912

  1. Oli Bartsch uploaded patch set 1 01/05/23, 14:03

  2. core-ci voted on patch set 1 V +1 01/05/23, 14:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35491

  3. Christian Kuhn commented on patch set 1 01/05/23, 14:58

    ElementInformationController.php:698

    This indicates no sys_file_reference record has been found. I guess it would be better to return ?array / null in this case and adapt the caller test accordingly?!
  4. Oli Bartsch uploaded patch set 2 V +1 01/05/23, 15:18

  5. Oli Bartsch commented on patch set 2 01/05/23, 15:18

    ElementInformationController.php:698 Reply

    Sounds reasonable. Done.
  6. Oli Bartsch uploaded patch set 3 01/05/23, 15:18

  7. Christian Kuhn voted on patch set 3 V +1 CR +1 01/05/23, 15:25

  8. core-ci voted on patch set 2 V +1 01/05/23, 15:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35496

  9. core-ci voted on patch set 3 V +1 01/05/23, 15:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35497

  10. Stefan Bürk voted on patch set 3 V +1 CR +1 01/05/23, 15:28

  11. Oli Bartsch voted on patch set 3 V +2 CR +2 01/05/23, 15:54

  12. Oli Bartsch merged patch set 4 01/05/23, 15:54