Review 11.5 Merged

77269[BUGFIX] Send correct content type for cached Extbase actions

Helmut Hummel CR +2 V +2 Easy +11 −24 updated 01/06/23, 15:24

Commit message

The setContentType method on TyposcripFrontendController
was introduced to allow Extbase plugins to change the
content-type header of the server http response.

However this currently only works, when the Extbase plugin
action is uncached. Once a plugin, that is rendered on a page
ist cached in page cache, the content type of subsequent
requests is always "text/html", because the value of the
contentType property is not stored in cache.

Storing this value into cache allows creating e.g.
Json APIs as Extbase Plugins, that can be fully cached
without adding hacks like modifying config.additionalHeaders

Review

  • Code review CR +2 Done
    • Helmut Hummel +2
  • Verified V +2 Done
    • Helmut Hummel +2
    • core-ci +1 CI

Issues 1

Files 4

Review log 57

  1. Helmut Hummel uploaded patch set 1 01/05/23, 23:28

  2. Helmut Hummel voted on patch set 1 V +2 CR +2 01/05/23, 23:30

  3. core-ci voted on patch set 1 V +1 01/05/23, 23:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35510

  4. Christian Kuhn updated the commit message in patch set 2 CR +2 V +1 01/06/23, 07:21

  5. core-ci voted on patch set 2 V +1 01/06/23, 07:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35518

  6. Helmut Hummel voted on patch set 2 V +2 CR +2 01/06/23, 15:22

  7. Helmut Hummel merged patch set 3 01/06/23, 15:24