Review main Merged Breaking

77274[!!!][FEATURE] Add PSR-14 Event for manipulating records in ContentContentObject

Joey Bouten CR +2 V +2 Hard +470 −13 updated 01/11/24, 16:10

Commit message

This introduces a new PSR-14 event, enabling
extension authors to modify the fetched records
as well as related options and configuration of
the `CONTENT` CcontentObject.

This replaces the previously available hook
$GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['tslib/class.tslib_content_content.php']['modifyDBRow']
which is therefore now removed.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Benni Mack +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Benni Mack +1

Issues 1

Files 8

Review log 2133

Show 58 earlier messages
  1. Joey Bouten uploaded patch set 1 01/06/23, 11:22

  2. core-ci voted on patch set 1 V -1 01/06/23, 11:29 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35528

  3. Christian Kuhn uploaded patch set 2 V -1 01/06/23, 15:28

  4. core-ci voted on patch set 2 V +1 01/06/23, 15:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35540

  5. Benni Mack commented on patch set 2 01/07/23, 19:17

    ContentContentObject.php:80

    you're calling the event twice. is that on purpose?
  6. Benni Mack commented on patch set 2 CR -1 01/07/23, 19:20

    ContentContentObject.php:78

    we could and should a) add various options such as $cobjValue, $slide, $slideCollect and $slideCollectFuzzy to it? So we could also render the $cobjValue and skip the default rendering? b) deprecate the hook further below? This event is much more powerful as you can juggle with all records all at once.
  7. Joey Bouten uploaded patch set 3 CR -1 V +1 01/09/23, 15:33

  8. core-ci voted on patch set 3 V +1 01/09/23, 15:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35608

  1. Joey Bouten uploaded patch set 4 V +1 01/09/23, 15:57

  2. Joey Bouten commented on patch set 4 01/09/23, 15:59

    ContentContentObject.php:78 Reply

    a) I have added the other available params. b) I added the deprecation notice, i have not added the deprecation documentation yet. Feel free to add this, i might have time later this week to add this myself.

    ContentContentObject.php:80 Reply

    Done
  3. core-ci voted on patch set 4 V -1 01/09/23, 16:09 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35609

  4. Benni Mack uploaded patch set 5 V -1 01/09/23, 23:02

  5. Benni Mack updated the commit message in patch set 6 01/09/23, 23:08

  6. Anja Leichsenring rebased onto patch set 7 01/20/23, 10:18

  7. core-ci voted on patch set 7 V -1 01/20/23, 10:29 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36317

  8. Benni Mack commented on patch set 8 V -1 03/24/23, 08:44

    Published edit on patch set 7.
  9. core-ci voted on patch set 8 V -1 03/24/23, 10:17 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39527

  10. Benni Mack uploaded patch set 9 V -1 03/24/23, 16:55

  11. core-ci voted on patch set 9 V +1 03/24/23, 17:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39579

  12. Benni Mack rebased onto patch set 10 V +1 01/09/24, 21:28

  13. core-ci voted on patch set 10 V -1 01/09/24, 21:34 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51356

  14. Oli Bartsch uploaded patch set 11 V -1 01/11/24, 14:44

  15. core-ci voted on patch set 11 V -1 01/11/24, 14:49 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51447

  16. Oli Bartsch uploaded patch set 12 V -1 01/11/24, 15:01

  17. core-ci voted on patch set 12 V +1 01/11/24, 15:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51448

  18. Benni Mack commented on patch set 12 01/11/24, 15:21

    ContentContentObject.php:78 Reply

    Done
  19. Oli Bartsch uploaded patch set 13 V +1 01/11/24, 15:59

  20. core-ci voted on patch set 13 V +1 01/11/24, 16:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51452

  21. Benni Mack uploaded patch set 14 V +1 01/11/24, 16:05

  22. Benni Mack voted on patch set 14 CR +1 V +1 01/11/24, 16:05

  23. Oli Bartsch voted on patch set 14 CR +2 V +2 01/11/24, 16:06

  24. Oli Bartsch merged patch set 15 01/11/24, 16:06

  25. core-ci voted on patch set 14 V +1 01/11/24, 16:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51453