77276[BUGFIX] Restore text selection correctly in RTE LinkBrowser
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Stefan Bürk +1
-
Verified V +2 Done
- Benni Mack +2
- Stefan Bürk +1
- Daniel Siepmann +1
- core-ci +1 CI
Issues 1
Files 4
Review log 1416
-
Benjamin Kott uploaded patch set 1 01/06/23, 13:36
-
core-ci voted on patch set 1 V +1 01/06/23, 13:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35535
-
Stefan Bürk commented on patch set 1 V +1 01/06/23, 14:27
could reproduce the issue with `firefox 108.0.1 (64-Bit) Linux Mint`. Can verify so far that this patch fixes the issue there and the link handling in RTE field is working as it can be expected. -
Stefan Bürk voted on patch set 1 CR +1 01/06/23, 14:30
-
Karsten Nowak commented on patch set 1 V +1 01/06/23, 14:31
Works fine in Firefox 108.0.2 (64-Bit) on Ubuntu 22.04.1 LTS. But I can't reproduce the error before. It just works here. With and without the patch. -
Karsten Nowak commented on patch set 1 01/06/23, 14:39
Reply
I checked again in TYPO3 12.1.3. There I can reproduce the error. Therefore, for me also resolved now. -
Daniel Siepmann voted on patch set 1 V +1 01/09/23, 07:36
-
Daniel Siepmann commented on patch set 1 01/09/23, 07:37
typo3-link.ts:317The sentence sounds weird, I guess it should be: LinkBrowser after clicking on the "Edit" button. -
Daniel Siepmann commented on patch set 1 01/09/23, 07:38
Could verify this patch fixes the issue in Firefox 108.0.1 (64-bit). It still doesn't work without the fix. -
Benjamin Kott uploaded patch set 2
CR +1V +101/09/23, 08:08 -
Benjamin Kott commented on patch set 2 01/09/23, 08:08
fixed strange comment ;)typo3-link.ts:317ReplyDone -
Daniel Siepmann voted on patch set 2 V +1 01/09/23, 08:09
-
core-ci voted on patch set 2 V +1 01/09/23, 08:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35595
-
Stefan Bürk voted on patch set 2 V +1 CR +1 01/09/23, 08:46
-
Benni Mack voted on patch set 2 V +2 CR +2 01/09/23, 21:52
-
Benni Mack merged patch set 3 01/09/23, 21:52