Review main Merged

77276[BUGFIX] Restore text selection correctly in RTE LinkBrowser

Benjamin Kott CR +2 V +2 Normal +29 −31 updated 01/09/23, 21:52

Commit message

In Firefox the editor loses the text selection information
after opening the Link Browser. Instead of using the
references, we are now passing the selection start and
end positions to the link browser to restore the text
selection.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Stefan Bürk +1
  • Verified V +2 Done
    • Benni Mack +2
    • Stefan Bürk +1
    • Daniel Siepmann +1
    • core-ci +1 CI

Issues 1

Files 4

Review log 1416

  1. Benjamin Kott uploaded patch set 1 01/06/23, 13:36

  2. core-ci voted on patch set 1 V +1 01/06/23, 13:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35535

  3. Stefan Bürk commented on patch set 1 V +1 01/06/23, 14:27

    could reproduce the issue with `firefox 108.0.1 (64-Bit) Linux Mint`. Can verify so far that this patch fixes the issue there and the link handling in RTE field is working as it can be expected.
  4. Stefan Bürk voted on patch set 1 CR +1 01/06/23, 14:30

  5. Karsten Nowak commented on patch set 1 V +1 01/06/23, 14:31

    Works fine in Firefox 108.0.2 (64-Bit) on Ubuntu 22.04.1 LTS. But I can't reproduce the error before. It just works here. With and without the patch.
  6. Karsten Nowak commented on patch set 1 01/06/23, 14:39

    Reply

    I checked again in TYPO3 12.1.3. There I can reproduce the error. Therefore, for me also resolved now.
  7. Daniel Siepmann voted on patch set 1 V +1 01/09/23, 07:36

  8. Daniel Siepmann commented on patch set 1 01/09/23, 07:37

    typo3-link.ts:317

    The sentence sounds weird, I guess it should be: LinkBrowser after clicking on the "Edit" button.
  9. Daniel Siepmann commented on patch set 1 01/09/23, 07:38

    Could verify this patch fixes the issue in Firefox 108.0.1 (64-bit). It still doesn't work without the fix.
  10. Benjamin Kott uploaded patch set 2 CR +1 V +1 01/09/23, 08:08

  11. Benjamin Kott commented on patch set 2 01/09/23, 08:08

    fixed strange comment ;)

    typo3-link.ts:317 Reply

    Done
  12. Daniel Siepmann voted on patch set 2 V +1 01/09/23, 08:09

  13. core-ci voted on patch set 2 V +1 01/09/23, 08:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35595

  14. Stefan Bürk voted on patch set 2 V +1 CR +1 01/09/23, 08:46

  15. Benni Mack voted on patch set 2 V +2 CR +2 01/09/23, 21:52

  16. Benni Mack merged patch set 3 01/09/23, 21:52