Review main Merged

77313[BUGFIX] Resolve nested TypoScript reference operator

Christian Kuhn CR +2 V +2 Easy +42 −1 updated 01/10/23, 15:17

Commit message

Incoming TS:

lib.foo = TEXT
lib.foo.value = foo
lib.bar =< lib.foo
lib.bar.value = bar
page = PAGE
page.10 = CASE
page.10.key.field = cache_timeout
page.10.default =< lib.foo
page.10.60 =< lib.bar

page.10.60 is a reference to lib.bar which sets the
sub property 'value' to 'bar'. lib.bar itself is a
reference to lib.foo which sets 'TEXT'. When the
cache timeout of a page is set to '60', string 'bar'
should be output.

This stopped working in main since the reference
resolving is not recursive anymore since #99060.

The patch fixes this and adds a unit test to verify.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Achim Fritz +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Achim Fritz +1
    • core-ci +1 CI

Issues 3

Files 2

Review log 911

  1. Christian Kuhn uploaded patch set 1 01/10/23, 11:45

  2. core-ci voted on patch set 1 V +1 01/10/23, 11:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35641

  3. Stefan Bürk commented on patch set 1 01/10/23, 12:10

    ContentObjectRenderer.php:4809

    Shouldn't this be `$propertyName` instad of hardcoded string `tempKey` ? Looks like hardcoded value from introduced testcase ....
  4. Christian Kuhn commented on patch set 1 01/10/23, 13:37

    ContentObjectRenderer.php:4809 Reply

    'tempKey' comes from cObjGetSingle(). But you're correct, it should be $propertyName.
  5. Christian Kuhn uploaded patch set 2 V +1 01/10/23, 13:39

  6. Christian Kuhn commented on patch set 2 01/10/23, 13:39

    ContentObjectRenderer.php:4809 Reply

    Done
  7. Achim Fritz voted on patch set 2 V +1 CR +1 01/10/23, 13:40

  8. Stefan Bürk voted on patch set 2 V +1 CR +1 01/10/23, 13:41

  9. core-ci voted on patch set 2 V +1 01/10/23, 13:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35646

  10. Stefan Bürk voted on patch set 2 V +2 CR +2 01/10/23, 15:17

  11. Stefan Bürk merged patch set 3 01/10/23, 15:17