77316[BUGFIX] Do not query database for non-existent records
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Stephan Großberndt +1
- Stefan Froemken +1
- Andreas Kienast +1
-
Verified V +2 Done
- Christian Kuhn +2
- Stephan Großberndt +1
- core-ci +1 CI
Issues 1
Files 1
Review log 2022
-
Markus Klein uploaded patch set 1 01/10/23, 12:31
-
Georg Ringer voted on patch set 1 V +1 CR +1 01/10/23, 12:38
-
core-ci voted on patch set 1 V +1 01/10/23, 12:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35644
-
Stephan Großberndt voted on patch set 1 V +1 CR +1 01/10/23, 12:43
-
Stefan Froemken commented on patch set 1 01/10/23, 12:58
-
Christian Kuhn voted on patch set 1 CR -1 01/10/23, 13:04
-
Markus Klein commented on patch set 1 01/10/23, 13:08
DataMapper.php:580ReplyI'll wait for more feedback and will eventually do this too then. -
Christian Kuhn voted on patch set 1 CR 0 01/10/23, 13:19
-
Stefan Froemken voted on patch set 1 CR +1 01/10/23, 13:25
-
Christian Kuhn commented on patch set 1 01/10/23, 13:35
Unsure about v11 from a risk assessment point of view, but I'd definitely skip v10. Other than that, it looks good from digging into the code. -
Markus Klein uploaded patch set 2
CR +1V +101/10/23, 13:40 -
Markus Klein commented on patch set 1 01/10/23, 13:40
DataMapper.php:580ReplyDone -
Christian Kuhn voted on patch set 2 CR +1 01/10/23, 13:41
-
core-ci voted on patch set 2 V +1 01/10/23, 13:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35647
-
Stefan Froemken voted on patch set 2 CR +1 01/10/23, 14:06
-
Stephan Großberndt voted on patch set 2 V +1 CR +1 01/10/23, 16:27
-
Oliver Hader commented on patch set 2 01/11/23, 08:15
DataMapper.php:342What about changing this to `empty($fieldValue)` as well? -
Markus Klein commented on patch set 2 01/11/23, 08:52
DataMapper.php:342ReplyI tried this, and thought about it, but didn't dare, because: This code path is also executed for other relation types. If inline fields contain the number of records or so. It shouldn't matter at this point. I actually doubt that this condition is ever true, once this patch is applied in its current form. -
Andreas Kienast voted on patch set 2 CR +1 02/06/23, 16:44
-
Christian Kuhn voted on patch set 2 V +2 CR +2 02/06/23, 16:44
-
Christian Kuhn commented on patch set 2 02/06/23, 16:45
DataMapper.php:342ReplyAck -
Christian Kuhn merged patch set 3 02/06/23, 16:52
DataMapper.php:580