77317[BUGFIX] Provide tag to add JavaScript Modules to importmap in Backend Form
Commit message
Review
-
Code review CR +2 Done
- Georg Ringer +2
- Benjamin Franzke +1
-
Verified V +2 Done
- Georg Ringer +2
- Benjamin Franzke +1
- Rico Drexler +1
- Jan Delius +1
- core-ci +1 CI
Issues 1
Files 5
- typo3/sysext/backend/Classes/Controller/EditDocumentController.php+1 −0
- typo3/sysext/backend/Configuration/JavaScriptModules.php+1 −0
- typo3/sysext/core/Documentation/Changelog/12.2/Important-99490-ProvideTagToAddJavaScriptModulesToImportmapInBackendForm.rstnew+49 −0
- typo3/sysext/rte_ckeditor/Configuration/JavaScriptModules.php3+3 −0
- typo3/sysext/t3editor/Configuration/JavaScriptModules.php+3 −0
Review log 1113
-
Benjamin Kott uploaded patch set 1 01/10/23, 12:36
-
Oliver Hader commented on patch set 1 01/10/23, 12:39
-
core-ci voted on patch set 1 V +1 01/10/23, 12:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35645
-
Oliver Hader commented on patch set 1 01/10/23, 12:45
JavaScriptModules.php:8ReplySince `backend.form` relates to `TYPO3\CMS\Backend\Form` it should be fine. -
Benjamin Kott uploaded patch set 2
V +101/10/23, 13:46 -
Benjamin Kott commented on patch set 2 01/10/23, 13:48
JavaScriptModules.php:8ReplyDone -
Benjamin Kott commented on patch set 2 01/10/23, 13:50
would be nice if @BenjaminFranzke would also review the patch. -
core-ci voted on patch set 2 V +1 01/10/23, 13:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35648
-
Jan Delius voted on patch set 2 V +1 01/10/23, 13:55
-
Rico Drexler voted on patch set 2 V +1 01/10/23, 14:14
-
Benjamin Franzke commented on patch set 2 V +1 CR +1 01/10/23, 14:54
Yup, we do need that tag. Looks good! -
Georg Ringer voted on patch set 2 V +2 CR +2 01/10/23, 15:18
-
Georg Ringer merged patch set 3 01/10/23, 15:18
JavaScriptModules.php:8