Review main Merged

77319[TASK] Remove obsolete hack in TsConfigTreeBuilder

Christian Kuhn CR +2 V +2 Easy +0 −7 updated 01/10/23, 15:07

Commit message

UserTs building has a hack for sys_note setting
TCAdefaults.sys_note.author and
TCAdefaults.sys_note.email.

These two fields have been removed from table sys_note
in 6.0, the options are useless and can be removed:
The creating user uid is stored in field 'cruser',
resolving to human readable names is done when rendering
notes.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Stefan Bürk +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 2

Files 2

Review log 57

  1. Christian Kuhn uploaded patch set 1 01/10/23, 14:49

  2. Christian Kuhn uploaded patch set 2 01/10/23, 14:52

  3. core-ci voted on patch set 2 V +1 01/10/23, 15:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35653

  4. core-ci voted on patch set 1 V -1 01/10/23, 15:01 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35652

  5. Stefan Bürk voted on patch set 2 V +1 CR +1 01/10/23, 15:02

  6. Georg Ringer voted on patch set 2 V +2 CR +2 01/10/23, 15:07

  7. Georg Ringer merged patch set 3 01/10/23, 15:07