Review main Merged

77326[TASK] Enhance CKEditor5 whitespace plugin handling

Benjamin Kott CR +2 V +2 Normal +167 −17 updated 01/20/23, 10:47

Commit message

This patch ensures that the whitespace plugin is correctly
removed, this includes the plugin itself and the toolbar item.
An additional plugin map of "softhyphen" to "Whitespace"
ensures that existing configurations are respected as well.
If the "softhyphen" Plugin was configured to be removed,
it will now remove the "Whitespace" plugin that is a
replacement.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Andreas Kienast +1
  • Verified V +2 Done
    • Benni Mack +2
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 913

  1. Benjamin Kott uploaded patch set 1 01/11/23, 09:26

  2. core-ci voted on patch set 1 V -1 01/11/23, 09:33 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35672

  3. Benjamin Kott uploaded patch set 2 V -1 01/20/23, 07:50

  4. core-ci voted on patch set 2 V +1 01/20/23, 07:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36296

  5. Markus Klein commented on patch set 3 V +1 01/20/23, 08:23

    Published edit on patch set 2.
  6. Markus Klein voted on patch set 3 V +1 CR +1 01/20/23, 08:23

  7. core-ci voted on patch set 3 V +1 01/20/23, 08:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36298

  8. Andreas Kienast commented on patch set 3 CR -1 01/20/23, 10:02

    on it

    CKEditor5Migrator.php:614

    in_array() instead of array_search()
  9. Andreas Kienast uploaded patch set 4 CR +1 V +1 01/20/23, 10:04

  10. Andreas Kienast commented on patch set 4 V +1 CR +1 01/20/23, 10:04

    CKEditor5Migrator.php:614 Reply

    Done
  11. core-ci voted on patch set 4 V +1 01/20/23, 10:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36316

  12. Benni Mack voted on patch set 4 V +2 CR +2 01/20/23, 10:47

  13. Benni Mack merged patch set 5 01/20/23, 10:47