Review main Merged

77330[TASK] Deprecate PageRepository->getExtURL()

Benni Mack CR +2 V +2 Normal +77 −5 updated 01/16/23, 19:52

Commit message

PageRepository->getExtURL() is a pretty upgly
public helper method that has a depedency to
$GLOBALS['TYPO3_REQUEST']. It is used only once.
The patch moves the method body to the consuming
class and deprecates it.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Jasmina Ließmann +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Jasmina Ließmann +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 5

Review log 1217

  1. Benni Mack uploaded patch set 1 01/11/23, 13:09

  2. core-ci voted on patch set 1 V -1 01/11/23, 13:18 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35683

  3. Christian Kuhn uploaded patch set 2 V -1 01/16/23, 17:45

  4. Christian Kuhn voted on patch set 2 V +1 CR +1 01/16/23, 17:51

  5. core-ci voted on patch set 2 V +1 01/16/23, 17:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35867

  6. Jasmina Ließmann commented on patch set 3 CR +1 V +1 01/16/23, 18:57

    Published edit on patch set 2.
  7. Jasmina Ließmann voted on patch set 3 V +1 CR +1 01/16/23, 18:58

  8. Oli Bartsch commented on patch set 3 CR -1 01/16/23, 19:06

    On it
  9. core-ci voted on patch set 3 V +1 01/16/23, 19:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35876

  10. Oli Bartsch uploaded patch set 4 CR +1 V +1 01/16/23, 19:14

  11. Oli Bartsch voted on patch set 4 V +1 CR +1 01/16/23, 19:14

  12. Christian Kuhn voted on patch set 4 V +1 CR +1 01/16/23, 19:16

  13. Jasmina Ließmann voted on patch set 4 V +1 CR +1 01/16/23, 19:16

  14. core-ci voted on patch set 4 V -1 01/16/23, 19:32 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35880

  15. core-ci voted on patch set 4 V +1 01/16/23, 19:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35880

  16. Oli Bartsch voted on patch set 4 V +2 CR +2 01/16/23, 19:52

  17. Oli Bartsch merged patch set 5 01/16/23, 19:52