Review main Merged

77331[TASK] Avoid last usage of BU::getFuncMenu() and deprecate

Christian Kuhn CR +2 V +2 Normal +146 −50 updated 01/12/23, 11:54

Commit message

With more and more refactoring of the backend controllers
and improving controller/view separation, usages of old
BackendUtility menu rendering helper methods are shrinking.

The patch refactors a last usage of BackendUtility::getFuncMenu()
and deprecates the method.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 9

Review log 1014

  1. Christian Kuhn uploaded patch set 1 01/11/23, 14:03

  2. Christian Kuhn uploaded patch set 2 01/11/23, 14:04

  3. core-ci voted on patch set 2 V -1 01/11/23, 14:14 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35687

  4. core-ci voted on patch set 1 V -1 01/11/23, 14:15 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35686

  5. Christian Kuhn uploaded patch set 3 V -1 01/11/23, 14:23

  6. core-ci voted on patch set 3 V +1 01/11/23, 14:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35689

  7. Stefan Bürk commented on patch set 3 01/12/23, 09:39

    Deprecation-99519-DeprecatedBackendUtilitygetFuncMenu.rst:6

    `Breaking`? Shouldn't this be `Deprecation` ? (like the filename)
  8. Stefan Bürk uploaded patch set 4 V +1 01/12/23, 10:46

  9. core-ci voted on patch set 4 V +1 01/12/23, 10:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35717

  10. Stefan Bürk voted on patch set 4 V +1 CR +1 01/12/23, 10:55

  11. Christian Kuhn commented on patch set 4 01/12/23, 11:43

    Deprecation-99519-DeprecatedBackendUtilitygetFuncMenu.rst:6 Reply

    Thx. Missed that, clicked wrong cat in forger first and renamed file.
  12. Benni Mack voted on patch set 4 V +1 CR +1 01/12/23, 11:44

  13. Christian Kuhn voted on patch set 4 V +2 CR +2 01/12/23, 11:54

  14. Christian Kuhn merged patch set 5 01/12/23, 11:54